<p>Prevent failure of <code>testConvertClearNode()</code> on some machines, caused by use of <code>InetAddress.getHostName</code> on the mock peer address. This does a reverse DNS lookup and potentially returns something other than the expected "192.168.0.1" string. (For example, on my current local network I get "BrightBox.ee".)</p>
<p>Also avoid an unnecessary <code>getHostName()</code> call on the SOCKS5 Tor proxy InetAddress in <code>WalletConfig</code>, by using an alternative <code>InetSocketAddress</code> constructor.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5083'>https://github.com/bisq-network/bisq/pull/5083</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Avoid reverse DNS lookup in BtcNodeConverterTest</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5083/files#diff-3b2440cf0088e50ee4befa9b6ea071cc40c003764e3368f0adb141b9aea3073e">core/src/main/java/bisq/core/btc/setup/WalletConfig.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5083/files#diff-8abdb79a4b7066f1635309bd4cb4e59eb121c3ccbc81e4bed22f7008c697684a">core/src/test/java/bisq/core/btc/nodes/BtcNodeConverterTest.java</a>
    (5)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5083.patch'>https://github.com/bisq-network/bisq/pull/5083.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5083.diff'>https://github.com/bisq-network/bisq/pull/5083.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5083">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWRQFBHMKBUJ2OQLKDS2BR4LANCNFSM4WEINJYQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUABHR7ZJZGDFA7F6LS2BR4LA5CNFSM4WEINJY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LXIZOZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5083",
"url": "https://github.com/bisq-network/bisq/pull/5083",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>