<p></p>
<p><b>@sqrrm</b> requested changes on this pull request.</p>
<p>Some minor changes.</p>
<p>I ran the scripts and I find the resulting orders strange, the price doesn't seem to correlate to the price feed, would like to understand what's happening there.</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5093#discussion_r560898873">apitest/scripts/trade-simulation.sh</a>:</p>
<pre style='color:#555'>> +RCVD_MSG=$($CMD)
+commandalert $? "Could not send confirmpaymentreceived message."
+printdate "${RCVD_MSG}"
+printbreak
+sleeptraced 4
+
+# Generate some btc blocks
+printdate "Generating btc blocks after fiat transfer."
+genbtcblocks 3 5
+printbreak
+sleeptraced 3
+
+# Complete the trade on the seller side.
+if [ "${DIRECTION}" = "BUY" ]
+then
+ printdate "BOB ${BOB_ROLE}: Closing trade by keeping funds in Bisq wallet."
</pre>
<p>Indent</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5093#discussion_r560898933">apitest/scripts/trade-simulation.sh</a>:</p>
<pre style='color:#555'>> +sleeptraced 4
+
+# Generate some btc blocks
+printdate "Generating btc blocks after fiat transfer."
+genbtcblocks 3 5
+printbreak
+sleeptraced 3
+
+# Complete the trade on the seller side.
+if [ "${DIRECTION}" = "BUY" ]
+then
+ printdate "BOB ${BOB_ROLE}: Closing trade by keeping funds in Bisq wallet."
+ CMD="$CLI_BASE --port=${BOB_PORT} keepfunds --trade-id=${OFFER_ID}"
+ printdate "BOB CLI: ${CMD}"
+else
+ printdate "ALICE (taker): Closing trade by keeping funds in Bisq wallet."
</pre>
<p>Indent</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5093#discussion_r560901896">core/src/main/resources/help/canceloffer-help.txt</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,25 @@
+canceloffer
+
+NAME
+----
+canceloffer - cancel an existing offer to buy or sell BTC
+
+SYNOPSIS
+--------
+canceloffer
+ --offer-id=<offer-id>
+
+DESCRIPTION
+-----------
+Cancel an existing offer. The offer will be removed from other Bisq users' offer views.
</pre>
<p>Might be nice to add that fees paid will be forfeited.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5093#discussion_r560902858">core/src/main/resources/help/getmyoffer-help.txt</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,25 @@
+getmyoffer
+
+NAME
+----
+getmyoffer - get your offer to buy or sell BTC
+
+SYNOPSIS
+--------
+getmyoffer
+ --offer-id=<offer-id>
+
+DESCRIPTION
+-----------
+List one of your existing offer's details.
</pre>
⬇️ Suggested change
<pre style="color: #555">-List one of your existing offer's details.
+List one of your existing offers' details.
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5093#discussion_r560905251">core/src/main/resources/help/getoffer-help.txt</a>:</p>
<pre style='color:#555'>> +List an existing offer's details. The offer cannot be one of your own, and be
+available for the taking, or it will not be viewable.
</pre>
<p>This wording is a bit confusing. Better separate to something like "Must not be your own. Must be available for taking."</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5093#discussion_r560906396">core/src/main/resources/help/keepfunds-help.txt</a>:</p>
<pre style='color:#555'>> +NAME
+----
+keepfunds - keep BTC received during a trade in Bisq wallet
+
+SYNOPSIS
+--------
+keepfunds
+ --trade-id=<trade-id>
+
+DESCRIPTION
+-----------
+A BTC buyer completes the final step in the trade protocol by keeping received BTC in his
+Bisq wallet. This step may not seem necessary from the buyer's perspective, but it is
+necessary for correct transition of a trade's state to CLOSED, within the Bisq server.
+
+The alternative way to close out the trade is to sen the received BTC to an external
</pre>
⬇️ Suggested change
<pre style="color: #555">-The alternative way to close out the trade is to sen the received BTC to an external
+The alternative way to close out the trade is to send the received BTC to an external
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5093#discussion_r560906913">core/src/main/resources/help/sendbsq-help.txt</a>:</p>
<pre style='color:#555'>> +DESCRIPTION
+-----------
+Send BSQ from your Bisq wallet to an external BSQ address.
+
+OPTIONS
+-------
+--address
+ The destination BSQ address for the send transaction.
+
+--amount
+ The amount of BSQ to send.
+
+--tx-fee-rate
+ An optional transaction fee rate (sats/byte) for the transaction. The user is
+ responsible for choosing a fee rate that will be accepted by the network in a
+ reasonable amount of time, and the fee rate must be greater than 0.
</pre>
⬇️ Suggested change
<pre style="color: #555">- reasonable amount of time, and the fee rate must be greater than 0.
+ reasonable amount of time, and the fee rate must be greater than 1.
</pre>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5093#discussion_r560907371">core/src/main/resources/help/sendbtc-help.txt</a>:</p>
<pre style='color:#555'>> +DESCRIPTION
+-----------
+Send BTC from your Bisq wallet to an external BTC address.
+
+OPTIONS
+-------
+--address
+ The destination BTC address for the send transaction.
+
+--amount
+ The amount of BTC to send.
+
+--tx-fee-rate
+ An optional transaction fee rate (sats/byte) for the transaction. The user is
+ responsible for choosing a fee rate that will be accepted by the network in a
+ reasonable amount of time, and the fee rate must be greater than 0.
</pre>
⬇️ Suggested change
<pre style="color: #555">- reasonable amount of time, and the fee rate must be greater than 0.
+ reasonable amount of time, and the fee rate must be greater than 1.
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5093#pullrequestreview-572140416">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVRN4F4ZO2LMEAPPNTS23BBJANCNFSM4WJCEAOQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWIPZOLFWMRTPNEUFDS23BBJA5CNFSM4WJCEAO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEINCXAA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5093#pullrequestreview-572140416",
"url": "https://github.com/bisq-network/bisq/pull/5093#pullrequestreview-572140416",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>