<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #4532.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="703081528" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4532" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/4532/hovercard" href="https://github.com/bisq-network/bisq/issues/4532">#4532</a></p>
<p>Adds the ability for pre-release notifications to be sent by the admin key holder.<br>
Users have the option in Settings to subscribe for pre-release notifications. (Default=off).</p>
<hr>
<h3>Screenshots</h3>
<p>Generating a pre-release notification:</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/105566180-5ef5b700-5cf0-11eb-9d81-63ea00ce2202.png"><img src="https://user-images.githubusercontent.com/47253594/105566180-5ef5b700-5cf0-11eb-9d81-63ea00ce2202.png" alt="image" style="max-width:100%;"></a></p>
<p>User setting for subscribing to pre-release notifications:</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/105566191-6e750000-5cf0-11eb-8fd1-5f92740ed742.png"><img src="https://user-images.githubusercontent.com/47253594/105566191-6e750000-5cf0-11eb-8fd1-5f92740ed742.png" alt="image" style="max-width:100%;"></a></p>
<p>Notification of a pre-release:</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/105566218-9c5a4480-5cf0-11eb-9a9d-17bb7a268281.png"><img src="https://user-images.githubusercontent.com/47253594/105566218-9c5a4480-5cf0-11eb-9a9d-17bb7a268281.png" alt="image" style="max-width:100%;"></a></p>
<p>Notification link is shown in the footer bar (if subscribed) :</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/105566256-c7449880-5cf0-11eb-9938-6e6cda407514.png"><img src="https://user-images.githubusercontent.com/47253594/105566256-c7449880-5cf0-11eb-9938-6e6cda407514.png" alt="image" style="max-width:100%;"></a></p>
<hr>
<h3>Testing matrix for alert messages:</h3>
<p>The alert can be either a regular release notification, a pre-release notification, or simply an general-purpose message. This is a list of tests performed:</p>
<ul>
<li>Verify that a general text alert message can be sent by old and new clients.</li>
<li>Verify that a general text alert message can be received by old and new clients.</li>
<li>Verify that a general text alert message can be removed by old and new clients.</li>
<li>Verify that a software release message can be sent by old and new clients.</li>
<li>Verify that a software release message can be received by old and new clients.</li>
<li>Verify that a software release message can be removed by old and new clients.</li>
<li>Verify that a software PRE-release message can be sent by new clients.</li>
<li>Verify that a software PRE-release message can be received by new clients.</li>
<li>Verify that a software PRE-release message can be removed by new clients.</li>
<li>Verify that a software PRE-release message does not affect old clients (it is not seen).</li>
<li>Verify that a software PRE-release message removal does not affect old clients.</li>
<li>Verify that a software PRE-release message followed by a software release message for the same version is handled correctly.</li>
<li>Verify that the PRE-release message only pops up on clients that have opted-in via the User Preferences setting.</li>
<li>Verify that the footer PRE-release notification link only shows up on clients that have opted-in via the User Preferences setting.</li>
<li>Verify that if user responds with "Ignore this version" option the software release message is not shown again upon startup.</li>
<li>Verify that if user responds with "Ignore this version" option the software pre-release message is not shown again upon startup.</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/5108'>https://github.com/bisq-network/bisq/pull/5108</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add pre-release software update notifications</li>
<li>code cleanup</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-117ac03b38110fc1bbf54ff48a09be95edc9cb4a5c5ffcabfabd3a5ce57edfbf">core/src/main/java/bisq/core/alert/Alert.java</a>
(34)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-0acc7d00f8368b0f79485d84162b2beb9487b061fd2d31aeb529e06d7c10d299">core/src/main/java/bisq/core/app/BisqSetup.java</a>
(27)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-3117f0897492bb1e296445c33b6d902d7a030ac0b6c47072e33a7a7af4a67baf">core/src/main/java/bisq/core/user/Preferences.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-d49eba386225655d5e2e4e095a2eb85575be337ca6c067e5af76abdeb636bf46">core/src/main/java/bisq/core/user/PreferencesPayload.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-a6cc570e0f56a36136791beae8f497706216230467708be9343344cd953e5f08">core/src/main/resources/i18n/displayStrings.properties</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-60a81df610d10ccfb05dcd6679a5251f1eab85d02f95bfa8f564a71a69d14e6a">core/src/test/java/bisq/core/user/UserPayloadModelVOTest.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-9fdd025ee4129456ee0a657082f251661207eee6d24a85a34306f20ea09051c1">desktop/src/main/java/bisq/desktop/main/overlays/windows/DisplayAlertMessageWindow.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-4bc7244fff002eae2512d12b1c02411857ae61b9bcb73d10777700b84b39df1a">desktop/src/main/java/bisq/desktop/main/overlays/windows/SendAlertMessageWindow.java</a>
(31)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-929f68b5b84a02ac4d217565bee2964dda3228242737bd2f2a5ff3949b1f41cd">desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5108/files#diff-51dcd1d852312df65738ff2bd493fdb0f187f50fb7d7324158c8b57fc1de7da7">proto/src/main/proto/pb.proto</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/5108.patch'>https://github.com/bisq-network/bisq/pull/5108.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/5108.diff'>https://github.com/bisq-network/bisq/pull/5108.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5108">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSMYT3ZSS54UKEYSJ3S3IZJ5ANCNFSM4WPJ5PHA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVTVERE53JKRFM2HPTS3IZJ5A5CNFSM4WPJ5PHKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4LZ3J4IA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5108",
"url": "https://github.com/bisq-network/bisq/pull/5108",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>