<p>Ensure the trade statistics list in <code>TradesChartsView</code> doesn't go stale upon new statistics arrivals, by moving a <code>fillList()</code> call from the <em>onChangeConfirmed</em> currency combobox event handler to the listener of the <code>selectedTradeStatistics</code> <code>TradesChartsViewModel</code> field.</p>
<p>(Also avoid unnecessary use of an <code>ObservableList</code> as a temporary variable in the <code>fillList()</code> method.)</p>
<p>--</p>
<p>I first spotted this bug a little while ago and it appears to have been present since early November 2020, at least looking through the commit history, so it most likely affects both master and the current v1.5.5 release candidate.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5122'>https://github.com/bisq-network/bisq/pull/5122</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix stale trade stats list view when new entries arrive</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5122/files#diff-c07a4a25261a735296715e03648489d434fb39f93d11500ed770a58f21a8623e">desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java</a>
    (21)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5122.patch'>https://github.com/bisq-network/bisq/pull/5122.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5122.diff'>https://github.com/bisq-network/bisq/pull/5122.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5122">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWUULABHD2RO467473S4B7WHANCNFSM4WV6QAIQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNT77KRMQFU7QBNBG23S4B7WHA5CNFSM4WV6QAI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4L3JUV3Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5122",
"url": "https://github.com/bisq-network/bisq/pull/5122",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>