<p>This is preparatory work for no fee tx offers. There should be no<br>
behavioral changes with this commit.</p>
<p>Split OfferPayload into abstract OfferPayload and FeeTxOfferPayload with<br>
implementation. Instance variables need to reside in FeeTxOfferPayload<br>
in the same order as previously to keep the generated json contract<br>
format.</p>
<p>Contract is still using FeeTxOfferPayload as I don't think Contract<br>
will be used with any other OfferPayload type.</p>
<p>Only FeeTxOfferPayload will have the ability to update capabilities.<br>
It seems better to just delete the old offer and create a new one<br>
if there is no loss in doing so, which there won't be without the<br>
fee tx.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/5121'>https://github.com/bisq-network/bisq/pull/5121</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Refactor OfferPayload</li>
<li>Refactor rename protobuf.OfferPayload -> protobuf.FeeTxOfferPayload</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-95eb2e15e7182812f9c4518c5cbbb38d3c6fbb4ca8388f4600a5c1541ad29691">apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-1dd9914e3d0450d8cc1aaa2f15afa9836051911a41ecb287a813f9cd4f9f5afd">core/src/main/java/bisq/core/offer/CreateOfferService.java</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-9d8b559259b745675d370839e1092047391402c38d1bc6fc15d187f82aa0d9be">core/src/main/java/bisq/core/offer/FeeTxOfferPayload.java</a>
(394)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-7421f25cc1584830f6e575beb0aec9adfc30bc1360c52519f81af4d16fd3f29a">core/src/main/java/bisq/core/offer/Offer.java</a>
(95)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-0e130456e5fb2313c463d48b2112d64f0c71544eb136dfd2069f78daa405e032">core/src/main/java/bisq/core/offer/OfferPayload.java</a>
(408)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-5e151a76cef2e8ffea07c4d456f312d5eb446f0fa1b813c467b677a9323164c6">core/src/main/java/bisq/core/offer/OpenOfferManager.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-3c5f5cf8eced5b053128c4e28f4e69c3865b611e1521733321a23b88fd304dd7">core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-4918defdef4db0fca38f6eaf020e25581c0d0b5d80871898ad764410cc5dcc45">core/src/main/java/bisq/core/support/dispute/DisputeManager.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-5628741f4073603b515dea81ac8682aaba0aa5f11fe1f88eb6edeccb73779ce3">core/src/main/java/bisq/core/trade/Contract.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-5bb453b1605048b6c1d0f0802595a6c8cc5466deaf86e4dfa74092cfd3d29047">core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerCreateAndSignContract.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-3b4c0b5e5b6dbf212f0934f586bed864071fc0b0e04816b757c392f5713f1cee">core/src/main/java/bisq/core/trade/protocol/tasks/taker/TakerVerifyAndSignContract.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-f099e762eb187f7f8b74b0d0c584dc0f4f7173e745782f8ac11466dd03926a5b">core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-c6a97e89454f9bb1a96ab232eb2c7941451ce4102eafe864fca7a5b248e04a43">core/src/test/java/bisq/core/account/witness/AccountAgeWitnessServiceTest.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-948b42722f473976e73ae1aa9eb4003f95d2ad7c9a09d07dc13b76e228f053ba">core/src/test/java/bisq/core/offer/OfferMaker.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-105bf3d2295601dc942b79ccbd7b0148eaaaa1586d9a147a8558bf4d50ffa82d">core/src/test/java/bisq/core/offer/OfferTest.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-a3776f22849f450a0bbfd449e5d2d82039c89d061f20636bc4015c5879756a4f">core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-cdcaccb4ab7cf0b9eeb9f323bb20c7d8f79a9ee08f9839dcbc6c5d3724029537">core/src/test/java/bisq/core/trade/TradableListTest.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-4eb0728f6d064874cd2349e23024829991bf6d9d4f55a2b6f35a8de330d11880">core/src/test/java/bisq/core/util/ProtoUtilTest.java</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-41b34a44d2df26644ec2e93e7c7211540603530d5d8649b0545ec4963b5315d5">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-bda9ca1cc23b0260cedc822c7bb87231e022c46e07123bda09819dd350d303d2">desktop/src/test/java/bisq/desktop/main/market/trades/TradesChartsViewModelTest.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-407e9498f14aced7e424484c01868c0286e2c89ec5eda72b213da81baa1efae1">desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-1eb1e71843154131009b180aece13a2cb3ed9b4ade9ea8ccfe57ccf9ae27b682">desktop/src/test/java/bisq/desktop/maker/OfferMaker.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-4a8849a24f01704b567f2f3fbfa8dd50f56fb7122aeef1ff3674015b505c3f1a">desktop/src/test/java/bisq/desktop/util/DisplayUtilsTest.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5121/files#diff-51dcd1d852312df65738ff2bd493fdb0f187f50fb7d7324158c8b57fc1de7da7">proto/src/main/proto/pb.proto</a>
(10)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/5121.patch'>https://github.com/bisq-network/bisq/pull/5121.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/5121.diff'>https://github.com/bisq-network/bisq/pull/5121.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5121">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSIZUME3XK3KRYBQATS4AXFBANCNFSM4WVOZW7A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNS3PZMSRXPGLFJEXS3S4AXFBA5CNFSM4WVOZW7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4L3F44LA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5121",
"url": "https://github.com/bisq-network/bisq/pull/5121",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>