<p>Code duplication needs to be reduced as new scripts are added.</p>
<ul>
<li>
<p>Refactor the <code>createpaymentacct</code> functions.<br>
The steps required to create a payment account are still displayed, but only for Alice, not Bob.</p>
</li>
<li>
<p>Treat the trade protocol simulation as an atomic function.<br>
This will reduce 'main' simulation script size as new ones are added.</p>
</li>
<li>
<p>Move <code>createoffer</code> command generation to its own function.</p>
</li>
</ul>
<p>This PRs branch was created off <code>01-fix-bash-syntax</code>, and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="793498620" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5116" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5116/hovercard" href="https://github.com/bisq-network/bisq/pull/5116">#5116</a> needs to be reviewed and merged before this one.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5128'>https://github.com/bisq-network/bisq/pull/5128</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix bash syntax inconsistencies</li>
  <li>Refactor createpaymentacct and trade protocol functions</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5128/files#diff-b73c46b8aad2e367110e527d193887c67bf0cc98b400b6173016140e9573f5f5">apitest/scripts/limit-order-simulation.sh</a>
    (87)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5128/files#diff-4d23d51a2575fce849e0b395356e232b6bddacfc455928b72cb2713a7c400e50">apitest/scripts/trade-simulation-env.sh</a>
    (32)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5128/files#diff-f6cfdc7bbb86d68e3a6ca8527e7132148dbb49a7158f5780df3bf9209bf5a690">apitest/scripts/trade-simulation-utils.sh</a>
    (187)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5128/files#diff-bf66826ae6c033a94c8bb7f85bb7371d546246b086d9b8f8c2a9300cae7c75a6">apitest/scripts/trade-simulation.sh</a>
    (188)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5128.patch'>https://github.com/bisq-network/bisq/pull/5128.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5128.diff'>https://github.com/bisq-network/bisq/pull/5128.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5128">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRTSBYGY2R6CRYJLP3S4HTCLANCNFSM4WX4CFBQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNWEAUGQDOWJ7P7DI4LS4HTCLA5CNFSM4WX4CFB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4L3YVYUQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5128",
"url": "https://github.com/bisq-network/bisq/pull/5128",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>