<p></p>
<h3>Description</h3>
<ul>
<li>Old client created a buy offer with TransferWise and new client takes it</li>
<li>After payment received is clicked NPE was thrown in new client.</li>
</ul>
<pre><code>Feb.-01 10:24:42.818 [JavaFX Application Thread] INFO  b.d.m.p.p.s.s.SellerStep3View: User pressed the [Confirm payment receipt] button for Trade ngkpxbc 
Feb.-01 10:24:42.818 [JavaFX Application Thread] INFO  b.c.t.p.FluentProtocol$Condition: We received a PAYMENT_RECEIVED event at phase FIAT_SENT and state SELLER_RECEIVED_FIAT_PAYMENT_INITIATED_MSG, tradeId=ngkpxbc-69f8f84c-1488-4d6e-aa1c-9e38a498ad6e-154 
Feb.-01 10:24:42.818 [JavaFX Application Thread] INFO  bisq.core.trade.Trade: Set new state at SellerAsTakerTrade (id=ngkpxbc): SELLER_CONFIRMED_IN_UI_FIAT_PAYMENT_RECEIPT 
Feb.-01 10:24:42.819 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
Feb.-01 10:24:42.819 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= null 
Feb.-01 10:24:42.819 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.NullPointerException 
Feb.-01 10:24:42.823 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
java.lang.NullPointerException
        at bisq.desktop.main.portfolio.pendingtrades.PendingTradesView.isMaybeInvalidTrade(PendingTradesView.java:319)
        at bisq.desktop.main.portfolio.pendingtrades.PendingTradesView.access$100(PendingTradesView.java:105)
        at bisq.desktop.main.portfolio.pendingtrades.PendingTradesView$1$1.update(PendingTradesView.java:588)
        at bisq.desktop.main.portfolio.pendingtrades.PendingTradesView$1$1.lambda$updateItem$0(PendingTradesView.java:573)
</code></pre>
<p>Ignoring the NPE the trade still can be completed.</p>
<p>I wasn't able to re-produce this in this exact setup, but I think it might be worth to add a safe-guard.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/5144">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXTR7JUXQ7WJWSWTUDS4ZZF3ANCNFSM4W4OWX2A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQZBXSS5GP3WXF2JQTS4ZZF3A5CNFSM4W4OWX2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4L4TCAKA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/5144",
"url": "https://github.com/bisq-network/bisq/issues/5144",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>