<p></p>
<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>NACK - Trading does work across versions and also the upgrading does work as expected. The only thing I noticed is that if you are establishing a trade between an old an a new Amazon account the current client is seeing two empty fields which might leave the user confused what to do (see <code>buy giftcard at</code> and <code>country</code>). I think in that case we should advise the user to contact the peer in the trader chat to discuss on which country store the egift card has to be purchased at.</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/107753000-c74c1d00-6d1f-11eb-98a1-8a3bded7ebfe.png"><img src="https://user-images.githubusercontent.com/170962/107753000-c74c1d00-6d1f-11eb-98a1-8a3bded7ebfe.png" alt="Bildschirmfoto 2021-02-12 um 10 44 32" style="max-width:100%;"></a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5117#pullrequestreview-589308266">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSNKIXCA34CJ3INP2LS6T2UDANCNFSM4WSZ3CCQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRAWC52DFBIQZJ5DT3S6T2UDA5CNFSM4WSZ3CC2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEMQCC2Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5117#pullrequestreview-589308266",
"url": "https://github.com/bisq-network/bisq/pull/5117#pullrequestreview-589308266",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>