<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<p>I'm done with the review, but hold back on an ACK because I want to know if the old <code>BaseCurrencyNetwork#getDefaultMinFeePerVbyte</code> method can be removed if never to be used again.  (I'm chasing these min fee rate changes in the api+tests).</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5235#discussion_r582910779">core/src/main/java/bisq/core/user/Preferences.java</a>:</p>
<pre style='color:#555'>> @@ -907,7 +911,7 @@ public boolean getPayFeeInBtc() {
 
     public long getWithdrawalTxFeeInVbytes() {
         return Math.max(prefPayload.getWithdrawalTxFeeInVbytes(),
-                Config.baseCurrencyNetwork().getDefaultMinFeePerVbyte());
</pre>
<p>Will <code>BaseCurrencyNetwork.getDefaultMinFeePerVbyte()</code> be <code>@Deprecated</code> and/or removed?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5235#discussion_r582920486">core/src/main/java/bisq/core/provider/fee/FeeService.java</a>:</p>
<pre style='color:#555'>> @@ -157,14 +158,15 @@ public void onSuccess(@Nullable Tuple2<Map<String, Long>, Map<String, Long>> res
                         epochInSecondAtLastRequest = timeStampMap.get("bitcoinFeesTs");
                         final Map<String, Long> map = result.second;
                         txFeePerVbyte = map.get("BTC");
+                        minFeePerVByte = map.get("btcMinTxFee");
</pre>
<p>Just because this map key <code>btcMinTxFee</code> is used in at least one other class, should it be defined as a static field in one class to avoid typos?   I'm not sure, but it's something to consider...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5235#pullrequestreview-598668773">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWEZKQMQ75BHZQX3BTTAZT3VANCNFSM4YFYYYTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQUMRZCLEO7MRDKWJDTAZT3VA5CNFSM4YFYYYT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEOXPLZI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5235#pullrequestreview-598668773",
"url": "https://github.com/bisq-network/bisq/pull/5235#pullrequestreview-598668773",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>