<ul>
<li>
<p>Use the logger of the <code>gRPC</code> service throwing the exception, not the exception handler's logger.</p>
</li>
<li>
<p>Log <code>trade not found</code> exceptions as warnings instead cluttering the log with full stack traces.</p>
</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5249'>https://github.com/bisq-network/bisq/pull/5249</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Display buyer's cost in api's gettrade output</li>
  <li>Merge branch 'master' into 01-show-cost-in-trade-output</li>
  <li>Use the logger of the gRPC service throwing an exception</li>
  <li>Permit some gRPC excptions to be logged only as warning</li>
  <li>Log 'trade not found' a warning instead of full stack trace</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-f6cfdc7bbb86d68e3a6ca8527e7132148dbb49a7158f5780df3bf9209bf5a690">apitest/scripts/trade-simulation-utils.sh</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-9687777eeb1474070ca4255e431cc57c81fd0988ae088aaaf980aa7600f21b9d">cli/src/main/java/bisq/cli/ColumnHeaderConstants.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-dd71b2d8988605f241ad97f535ee27c5a5fc9da4f14baa400e4739375db5fe46">cli/src/main/java/bisq/cli/TradeFormat.java</a>
    (33)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-f375f6170c747c3f7f43207de7294b176d5f5bec8669141f50974a25b7969354">daemon/src/main/java/bisq/daemon/grpc/GrpcDisputeAgentsService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-bc6b772b057c68f8b6f8ffc31f14525ad90a2b3d407835d9e55ce9e5f70002e3">daemon/src/main/java/bisq/daemon/grpc/GrpcExceptionHandler.java</a>
    (18)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-e6b3ed377b998ee49d5f7d46b847926364827d3ba2593760ebf02040b5def05c">daemon/src/main/java/bisq/daemon/grpc/GrpcGetTradeStatisticsService.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-87b164c3ca31333a8a805fb211a24df3c60e8403c7757afa284b95dfc947a564">daemon/src/main/java/bisq/daemon/grpc/GrpcHelpService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-5afef68b74948ae40e71a3955d52c1bfd52fa4a95fed271c6cae61626089073d">daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-6d8b8c93482024d228b7265fa4533f5c1b9d2fc284f0e5e4c10f36d742f70dcb">daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-a96b59b7ba337e29b7f6c7fa2133dffabd15888baa9a81d968c237ac4169dba9">daemon/src/main/java/bisq/daemon/grpc/GrpcPriceService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-4edcf718e275d29ef43243696bd12ed380866fa97277367cfa0e43f77ce406d1">daemon/src/main/java/bisq/daemon/grpc/GrpcShutdownService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-0999abe6a76f18c5be810b6c5436cea6d708c11d99ed316d0397c3ebbc6aa777">daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-0f735437c30861df6592c3fa0c5ab71c170d9a7dfb14a063529ae4a9fcb6f251">daemon/src/main/java/bisq/daemon/grpc/GrpcVersionService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5249/files#diff-2599dd16bc53cae95cd20c7466d22e1a79ae172db0526cd14f7839cee29ad9fe">daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java</a>
    (28)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5249.patch'>https://github.com/bisq-network/bisq/pull/5249.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5249.diff'>https://github.com/bisq-network/bisq/pull/5249.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5249">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQJBU7KAO3PUSH5S2DTBFJOHANCNFSM4YKJDRRQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQBNTSVR65BNIOZRTDTBFJOHA5CNFSM4YKJDRR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MGB4MHA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5249",
"url": "https://github.com/bisq-network/bisq/pull/5249",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>