<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<p>The last part of commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/d01a7b7feec7167b66ec808529d2e63ffe248442/hovercard" href="https://github.com/bisq-network/bisq/commit/d01a7b7feec7167b66ec808529d2e63ffe248442"><tt>d01a7b7</tt></a> 's message is incorrect.  Commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/d01a7b7feec7167b66ec808529d2e63ffe248442/hovercard" href="https://github.com/bisq-network/bisq/commit/d01a7b7feec7167b66ec808529d2e63ffe248442"><tt>d01a7b7</tt></a> makes <em>empty</em> opt values invalid, and throws an exception with the conventional <code>no <opt> specified</code> error message. Before this change, the CLI's opt parser accepted <code>--offer-id=</code> as a valid option, with an empty value.</p>
<p>The <em>next</em> commit makes the option parser throw option parser exceptions due to  <em>missing (not empty)</em> option values.  The next commit will result in a stylistically consistent error message printed to the console when <code>--offer-id</code> is present without an <code>=</code> delimiter (as if it were a no-arg option).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5274#pullrequestreview-605334885">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNV6Z7FM5GHAXSEODR3TCDZXLANCNFSM4YTRFDTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUY3S26GVLWPC77GUDTCDZXLA5CNFSM4YTRFDT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEQKK2ZI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5274#pullrequestreview-605334885",
"url": "https://github.com/bisq-network/bisq/pull/5274#pullrequestreview-605334885",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>