<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5274#discussion_r590382446">cli/src/test/java/bisq/cli/opt/OptionParsersTest.java</a>:</p>
<pre style='color:#555'>> +                new CreateOfferOptionParser(args).parse());
+        assertEquals("no direction (buy|sell) specified", exception.getMessage());
+    }
+
+    @Test
+    public void testValidCreateOfferOpts() {
+        String[] args = new String[]{
+                PASSWORD_OPT,
+                createoffer.name(),
+                "--" + OPT_PAYMENT_ACCOUNT + "=" + "abc-payment-acct-id-123",
+                "--" + OPT_DIRECTION + "=" + "BUY",
+                "--" + OPT_CURRENCY_CODE + "=" + "EUR",
+                "--" + OPT_AMOUNT + "=" + "0.125",
+                "--" + OPT_MKT_PRICE_MARGIN + "=" + "0.0",
+                "--" + OPT_SECURITY_DEPOSIT + "=" + "25.0"
+        };
</pre>
<p>In next PR (<a href="https://github.com/bisq-network/bisq/pull/5284" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5284/hovercard">5284</a>) more asserts were added to check valid, parsed opt values in commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/389abf459d87f748dc0998490bc7332ac5a7ff3c/hovercard" href="https://github.com/bisq-network/bisq/commit/389abf459d87f748dc0998490bc7332ac5a7ff3c"><tt>389abf4</tt></a>.</p>
<pre><code> assertEquals("abc-payment-acct-id-123", parser.getPaymentAccountId());
        assertEquals("BUY", parser.getDirection());
        assertEquals("EUR", parser.getCurrencyCode());
        assertEquals("0.125", parser.getAmount());
        assertEquals("0.0", parser.getMktPriceMargin());
        assertEquals("25.0", parser.getSecurityDeposit());
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5274#discussion_r590382446">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWAPZF2HD2SEYPTMPLTCYRJVANCNFSM4YTRFDTQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUWTBRJEFCYLY5Z2MTTCYRJVA5CNFSM4YTRFDT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEQ2IQPI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5274#discussion_r590382446",
"url": "https://github.com/bisq-network/bisq/pull/5274#discussion_r590382446",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>