<p></p>
<p><b>@wallclockbuilder</b> requested changes on this pull request.</p>

<p>Add tests so we know its working and also get notified if something breaks this in the future.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5312#discussion_r594492946">desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java</a>:</p>
<pre style='color:#555'>> @@ -221,6 +228,52 @@ public void initialize() {
         withdrawMemoTextField = addTopLabelInputTextField(gridPane, ++rowIndex,
                 Res.get("funds.withdrawal.memoLabel", Res.getBaseCurrencyCode())).second;
 
+        Tuple3<Label, InputTextField, ToggleButton> customFeeTuple = addTopLabelInputTextFieldSlideToggleButton(gridPane, ++rowIndex,
</pre>
<p>You're reorganising 40 lines of code(more than 7lines i.e. readable). Where are the unit tests and/or end-to-end tests for this?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5312#discussion_r594493760">desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java</a>:</p>
<pre style='color:#555'>> @@ -221,6 +228,52 @@ public void initialize() {
         withdrawMemoTextField = addTopLabelInputTextField(gridPane, ++rowIndex,
                 Res.get("funds.withdrawal.memoLabel", Res.getBaseCurrencyCode())).second;
 
+        Tuple3<Label, InputTextField, ToggleButton> customFeeTuple = addTopLabelInputTextFieldSlideToggleButton(gridPane, ++rowIndex,
</pre>
<p>That way we know it works all the time, and we also know when it gets accidentally broken by some other feature.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5312#pullrequestreview-612401502">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRNP5NMRELEHZIGDJTTDYZGRANCNFSM4ZGT77AA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXRQ4CAH6I2UKQR6SLTDYZGRA5CNFSM4ZGT77AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOESAICXQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5312#pullrequestreview-612401502",
"url": "https://github.com/bisq-network/bisq/pull/5312#pullrequestreview-612401502",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>