<p>It is currently possible to create and take offers while not connected to the bitcoin network.</p>
<p>This should have been fixed by <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="738377016" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/4764" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/4764/hovercard" href="https://github.com/bisq-network/bisq/pull/4764">#4764</a> but that PR only considered the scenario where chainheight from the DAO was stale.</p>
<p>The fix is to also handle the other part of the equation, when the <strong>chainheight of bitcoin network peers is stale</strong>.</p>
<hr>
<p>Instances of this problem have been experienced with offers that have transactions not found by blockexplorers, as described in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="800882410" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5151" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/5151/hovercard" href="https://github.com/bisq-network/bisq/issues/5151">#5151</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="496785041" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/3305" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/3305/hovercard" href="https://github.com/bisq-network/bisq/issues/3305">#3305</a>.</p>
<hr>
<p><strong>To reproduce the issue:</strong></p>
<ul>
<li>Start Bisq, specifying a bitcoin node address that is not running a node.  (For regtest see <code>DEFAULT_REGTEST_HOST</code>)</li>
<li>Bisq will start up and display "Connecting to Bitcoin network" in the footer bar.</li>
<li>Create offers, take offers.  No error messages are displayed.</li>
</ul>
<p><strong>To verify the fix:</strong></p>
<ul>
<li>Start Bisq, specifying a bitcoin node address that is not running a node.  (For regtest see <code>DEFAULT_REGTEST_HOST</code>)</li>
<li>Bisq will start up and display "Connecting to Bitcoin network" in the footer bar.</li>
<li>Attempt to create offers, take offers.  You will be informed as that Bisq is not in sync with the network.</li>
</ul>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/111535603-4aa1c980-8737-11eb-8b9f-c4ac4b06eaf8.png"><img src="https://user-images.githubusercontent.com/47253594/111535603-4aa1c980-8737-11eb-8b9f-c4ac4b06eaf8.png" alt="image" style="max-width:100%;"></a></p>
<p>Network Settings:</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/111537770-d9174a80-8739-11eb-8b9e-40f938f33487.png"><img src="https://user-images.githubusercontent.com/47253594/111537770-d9174a80-8739-11eb-8b9e-40f938f33487.png" alt="image" style="max-width:100%;"></a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5325'>https://github.com/bisq-network/bisq/pull/5325</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>handle case where bitcoind chain height is stale</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5325/files#diff-7653fe88b27c966f6dd2f862c436fee5e5581ab2648c08888ac95afd7cd5c471">core/src/main/java/bisq/core/btc/setup/WalletsSetup.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5325/files#diff-a6cc570e0f56a36136791beae8f497706216230467708be9343344cd953e5f08">core/src/main/resources/i18n/displayStrings.properties</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5325.patch'>https://github.com/bisq-network/bisq/pull/5325.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5325.diff'>https://github.com/bisq-network/bisq/pull/5325.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5325">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTPBTH42K4KEP66RWDTEEKO5ANCNFSM4ZLLEXPQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQRJCXSNLZTVW4V3STTEEKO5A5CNFSM4ZLLEXP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MNYQ7SQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5325",
"url": "https://github.com/bisq-network/bisq/pull/5325",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>