<p>This bug fix makes sure encrypted wallet initialization happens during startup, without prompting the user for a wallet password.</p>
<ul>
<li>
<p>Block UI popups in api startup's encrypted wallet init.<br>
Running the UI's <code>walletPasswordHandler</code> during wallet initialization will block the API's wallet initialization.  This change ensures an encrypted wallet does not trigger <code>walletPasswordHandler.run()</code> if <code>isApiUser=true</code> during startup.</p>
</li>
<li>
<p>Set <code>WalletsManager</code> key in first <code>CoreWalletsService#unlockWallet</code> call.<br>
This is necessary because the key cannot be set during api daemon startup, which does happen during the UI's startup.  See commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/eb15fda229bd9481b11844ee95f2243613842034/hovercard" href="https://github.com/bisq-network/bisq/commit/eb15fda229bd9481b11844ee95f2243613842034"><tt>eb15fda</tt></a>.</p>
</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5337'>https://github.com/bisq-network/bisq/pull/5337</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Block UI popups in api startup's encrypted wallet init</li>
  <li>Set WalletsManager key if missing</li>
  <li>Fix typo</li>
  <li>Remove log statement, add comment</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5337/files#diff-f1df4fd99db45d9b91ec2a59f443619324e243cb5738a597ef8008b67cc97d9a">core/src/main/java/bisq/core/api/CoreWalletsService.java</a>
    (49)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5337/files#diff-136adf1382ff8437e452c4b6040fda2f1b5cd2943cb7ec4fe0de61bf1794aeca">core/src/main/java/bisq/core/app/AppStartupState.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5337/files#diff-9a6f03d75ea99c40f1246b9f34cabb964bea2fc57f7e7267deb2a90b05969e63">core/src/main/java/bisq/core/app/WalletAppSetup.java</a>
    (10)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5337.patch'>https://github.com/bisq-network/bisq/pull/5337.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5337.diff'>https://github.com/bisq-network/bisq/pull/5337.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5337">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNX7RSXVA7WXU5GWYVTTEULONANCNFSM4ZQ3H5DA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRBFEOGHFOATP6P3UTTEULONA5CNFSM4ZQ3H5DKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MPCMQHQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5337",
"url": "https://github.com/bisq-network/bisq/pull/5337",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>