<p>This change adds offer and trade contract detail to the API's Offer and Trade protos, and improves CLI output formatting.</p>
<ul>
<li>
<p>Appended missing fields to <code>OfferInfo</code> proto message:<br>
uint64 sellerSecurityDeposit = 20;<br>
string offerFeePaymentTxId = 21;<br>
uint64 txFee = 22;<br>
uint64 makerFee = 23;</p>
</li>
<li>
<p>Added new api proto messages <code>ContractInfo</code> and <code>PaymentAccountPayloadInfo</code>.<br>
Lighterweight protos are needed because core Trade/Contract classes are not visible to CLI.</p>
</li>
<li>
<p>Appended <code>ContractInfo</code> field to api proto message <code>TradeInfo</code>.</p>
</li>
<li>
<p>Added proto / model converters for <code>ContractInfo</code> and <code>PaymentAccountPayloadInfo</code>, and adjusted <code>OfferInfo</code> & <code>TradeInfo</code>.</p>
</li>
<li>
<p>Improved CLI output formatting. Added more trade detail to CLI's <code>gettrade</code> output, and prepared to support BTC/BSQ trading pair. <em>Note a reviewer is advised to look at the CLI outout formatting class files instead getting bogged down in the many commit changes.</em></p>
</li>
</ul>
<p>This is the 2bd PR in a series, with the goal of supporting the BTC/BSQ trading pair.<br>
PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="841341208" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5356" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5356/hovercard" href="https://github.com/bisq-network/bisq/pull/5356">#5356</a> must be reviewed/merge before this one.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/5357'>https://github.com/bisq-network/bisq/pull/5357</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add api method createcryptopaymentacct</li>
<li>Add cli side help for createcryptopaymentacct</li>
<li>Provide more offer & contract detail available to CLI.</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-afc5db1c8acb08dec253ee87a3e0e677c932d6826a2ab4c31ba816a4dcfb1386">cli/src/main/java/bisq/cli/CliMain.java</a>
(23)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-9687777eeb1474070ca4255e431cc57c81fd0988ae088aaaf980aa7600f21b9d">cli/src/main/java/bisq/cli/ColumnHeaderConstants.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-bc03e9b04d52b37f48d4f56aa608b4a50a2085dff40f9fc738d910ea5a72d599">cli/src/main/java/bisq/cli/CurrencyFormat.java</a>
(46)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-1394e8dd80ec0396efe909b1c65ddd4a76eaeccbe9d51095e55bfb92daf81293">cli/src/main/java/bisq/cli/DirectionFormat.java</a>
(60)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-ae5b5d0bb9a18998e885050698a2ce8dde809059fffc344f1d24a937e6ecbae3">cli/src/main/java/bisq/cli/GrpcClient.java</a>
(49)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-330baed45084180eea99af5e846a1c064bb8cebde98bcc24ad1c04d00efcb5b8">cli/src/main/java/bisq/cli/Method.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-2ac1e865aee578e0d675f0b5777c3c9ba660b165166cb7b031539face84c8559">cli/src/main/java/bisq/cli/TableFormat.java</a>
(166)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-dd71b2d8988605f241ad97f535ee27c5a5fc9da4f14baa400e4739375db5fe46">cli/src/main/java/bisq/cli/TradeFormat.java</a>
(145)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-916f1cea6bd3db8ae3895a8fb8a1151c2878033ba88d0f4045eedf22e9de2ae4">cli/src/main/java/bisq/cli/opts/ArgumentList.java</a>
(1)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-5bbbcb4ac606dd02df87723eb68c37ad7e3a6f09d8aa307f363bec7e33e74564">cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java</a>
(75)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-3415018205a8c6737f1f4f3a1086db8db2f84012cad20f71dda957130c9f69fe">cli/src/main/java/bisq/cli/opts/MethodOpts.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-c3491a41f640da451ad42a12869b1f6552f22c2fb56da31eeb1c01498a8b8203">cli/src/main/java/bisq/cli/opts/OptLabel.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-89bd90c4f1800a87fb80e3ec2076b5cecb78b4f3d681a657eccce55a486e8e04">cli/src/test/java/bisq/cli/opt/OptionParsersTest.java</a>
(89)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-fb5876d3b212d239a14d78529ac498b30a2dbb8e3f184ba9bd711a5d4901fb62">core/src/main/java/bisq/core/api/CoreApi.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-161be9419f5c0abf3098d8ac7d8b096a321bb76f0c26b5be11cc183958209368">core/src/main/java/bisq/core/api/CorePaymentAccountsService.java</a>
(50)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-f1df4fd99db45d9b91ec2a59f443619324e243cb5738a597ef8008b67cc97d9a">core/src/main/java/bisq/core/api/CoreWalletsService.java</a>
(20)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-f89b019de675b5a225783e06a1b316c0f2e3d17ed6aab8f47a1ab9796ee0926a">core/src/main/java/bisq/core/api/model/ContractInfo.java</a>
(126)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-3a9ff7695726e0660444b5b5e18600d2cff2bc2fcdf3f78c36a0fc3df504e1b6">core/src/main/java/bisq/core/api/model/OfferInfo.java</a>
(52)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-0ee6d746cd6c9f47730564789acdbc817a021fae26cf38fc1493c03e61ac0270">core/src/main/java/bisq/core/api/model/PaymentAccountForm.java</a>
(10)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-125dd314b5b329f56e28bb0c9addb2be230db2c1183b8309ed74a78448b02767">core/src/main/java/bisq/core/api/model/PaymentAccountPayloadInfo.java</a>
(76)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-5751067b75ae6f7739df840d815386f3998f04baff5de96c079f5ce1fe6b4f57">core/src/main/java/bisq/core/api/model/TradeInfo.java</a>
(63)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-0f421b3d29f6cd7b91f537f92b5c52c0144bf059d83ad9e7a897d416a88f68f8">core/src/main/java/bisq/core/api/model/TxInfo.java</a>
(22)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-68a0fcdcf30bce675a1c87cc2bc1c384b2b382389dc974f1e550311e75a9659b">core/src/main/resources/help/createcryptopaymentacct-help.txt</a>
(39)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-6d8b8c93482024d228b7265fa4533f5c1b9d2fc284f0e5e4c10f36d742f70dcb">daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java</a>
(37)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5357/files#diff-dcb44a0045a5b02cde5bd2f45051b7d9293f87180111c7ea57f0d0eb85d0f393">proto/src/main/proto/grpc.proto</a>
(47)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/5357.patch'>https://github.com/bisq-network/bisq/pull/5357.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/5357.diff'>https://github.com/bisq-network/bisq/pull/5357.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5357">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNX4B6I7QPAIWCQ2JH3TFO2GTANCNFSM4Z2HXPAQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVLEHNKA5SFXHPR7G3TFO2GTA5CNFSM4Z2HXPA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MRGJHTQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5357",
"url": "https://github.com/bisq-network/bisq/pull/5357",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>