<p></p>
<p><b>@wallclockbuilder</b> approved this pull request.</p>

<p>Created an offer, then set <code>marketPrice=null;</code><br>
Tried viewing the offer.<br>
Got this error in the UI and the following error log.<br>
<code>[JavaFX Application Thread] ERROR b.c.s.CommonSetup: Stack trace: java.lang.NullPointerException at bisq.core.offer.TriggerPriceService.wasTriggered(TriggerPriceService.java:125) at bisq.core.offer.TriggerPriceService.checkPriceThreshold(TriggerPriceService.java:140) at bisq.core.offer.TriggerPriceService.lambda$onPriceFeedChanged$4(TriggerPriceService.java:108) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177) at java.base/java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1608) </code><br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/2033945/113217886-6aef7f00-9233-11eb-8c9c-9b3bde7ead1a.png"><img src="https://user-images.githubusercontent.com/2033945/113217886-6aef7f00-9233-11eb-8c9c-9b3bde7ead1a.png" alt="null pointer exception" style="max-width:100%;"></a></p>
<p>I'm able to view the offer just fine when the null value is guarded.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5385#pullrequestreview-625760294">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRNVG6LIOGLYH2JKFTTGONA3ANCNFSM42FOVG3Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTMICQOAYJ6UZPLMCLTGONA3A5CNFSM42FOVG32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEVGFQJQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5385#pullrequestreview-625760294",
"url": "https://github.com/bisq-network/bisq/pull/5385#pullrequestreview-625760294",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>