<p>Fixes <code>seller-cant-confirm</code> issue by transitioning past <code>BuyerSendCounterCurrencyTransferStartedMessage</code> only after an <code>AckMessage</code> response.  Previously it would transition upon mailbox message delivery.</p>
<p>Scenario from log of issue <code>aTPPev</code> (and others) :</p>
<ul>
<li>Alice creates an offer to buy.  Bob takes the offer.  Blockchain confirms.</li>
<li>Alice initiates fiat payment and clicks on Payment sent.</li>
<li>12 seconds later Alice clicks Payment sent.</li>
<li>11 seconds later Alice clicks Payment sent.</li>
<li>12 seconds later Alice clicks Payment sent.</li>
<li>9 seconds later Alice log receives "Message arrived at peer" (4 times).</li>
<li>Alice transitions to the next step and no longer has the option to click Payment sent.</li>
<li>[10 hours passes], Ack message has <strong>not</strong> been received from Bob.</li>
<li>Bob is still waiting for <code>BuyerSendCounterCurrencyTransferStartedMessage</code>, so he can not click on "Payment received".</li>
<li>Alice and Bob exchange chat messages and eventually open a Dispute.</li>
</ul>
<p>In the scenario above, Alice would keep being prompted to "send confirmation again" (until she receives AckMessage) and eventually DM with Bob to ask what the issue is.</p>
<ul>
<li>Bob might say he has <strong>not</strong> received payment notification, he could restart Bisq and maybe the message would go through,</li>
<li>or Bob might have already transitioned to showing the "Confirm Payment Receipt" button, and therefore could pay out the trade.</li>
<li>The trade can be paid out normally even if Alice has the Payment started button showing.  As long as Bob processes a <code>BuyerSendCounterCurrencyTransferStartedMessage</code> => can click "Confirm Payment Receipt".</li>
<li>This fix gives more chance for <code>BuyerSendCounterCurrencyTransferStartedMessage</code> to be re-sent.</li>
</ul>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/114205635-1f6a5e80-9920-11eb-848a-0c356f2febc3.png"><img src="https://user-images.githubusercontent.com/47253594/114205635-1f6a5e80-9920-11eb-848a-0c356f2febc3.png" alt="image" style="max-width:100%;"></a></p>
<p>tag <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/chimp1984/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/chimp1984">@chimp1984</a> pls <g-emoji class="g-emoji" alias="eyes" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f440.png">👀</g-emoji></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5401'>https://github.com/bisq-network/bisq/pull/5401</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Wait for AckMessage before completing task</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5401/files#diff-9ad0b6b75e28d8a0331ac0d8d11803cf61e6d68bbc61da3a0ee2a9563e5d3ef8">core/src/main/java/bisq/core/trade/protocol/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java</a>
    (20)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5401.patch'>https://github.com/bisq-network/bisq/pull/5401.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5401.diff'>https://github.com/bisq-network/bisq/pull/5401.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5401">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSX4G2M6YGJVXUG3SDTH4QAXANCNFSM42VHTEMA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXYW3DSYPVM4PRSRWDTH4QAXA5CNFSM42VHTEMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MXQ7PZA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5401",
"url": "https://github.com/bisq-network/bisq/pull/5401",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>