<p></p>
<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5312#discussion_r612985065">desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java</a>:</p>
<pre style='color:#555'>> -    private InputTextField transactionFeeInputTextField, ignoreTradersListInputTextField, ignoreDustThresholdInputTextField,
+    private InputTextField ignoreTradersListInputTextField, ignoreDustThresholdInputTextField,
</pre>
<p>You just restored the reference for the InputTextField, but still removed the creation and functionality of it in Preferences. What I meant was to restore the functionality as it was before, but extract the UI element creation and most of it's functionality to FormBuilder and GUIUtil to prevent unnecessary duplication. Afterwards most of it can be re-used or adapted for the BSQ custom fee setting as well and removed from Preferences completely.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5312#discussion_r612985065">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQQQUTBLWNNHVKX3LTTIU4GHANCNFSM4ZGT77AA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNQS2VAWE5HINFISVQTTIU4GHA5CNFSM4ZGT77AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEXOXNKI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5312#discussion_r612985065",
"url": "https://github.com/bisq-network/bisq/pull/5312#discussion_r612985065",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>