<p>The test harness is compatible with bitcoin-core 0.19, 0.20, 0.21.</p>
<p>Also removed some unnecessary comments about registering dispute agents in the test harness because it now happens by default.</p>
<p>PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="861419256" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5420" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5420/hovercard" href="https://github.com/bisq-network/bisq/pull/5420">#5420</a> needs to be reviewed/merged before this one.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/5421'>https://github.com/bisq-network/bisq/pull/5421</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add verifyBsqSentToAddress to GrpcWalletsService, CoreApi</li>
<li>Complete API support for BSQ/BTC trade pair</li>
<li>Test BSQ/BTC trade pair</li>
<li>Configure call rate meter for CreateCryptoCurrencyPaymentAccount</li>
<li>Remove white space in console msg</li>
<li>Adjust to changing minimum tx fee rates</li>
<li>Update apitest docs for bitcoin-core v0.21 compat</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-6a54058c81f798cd70d475e511e3afa76c3c8b629529065c5f099176f3b47324">apitest/docs/api-beta-test-guide.md</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-b73c46b8aad2e367110e527d193887c67bf0cc98b400b6173016140e9573f5f5">apitest/scripts/limit-order-simulation.sh</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-fc46183d63acb3c6cdf3c375d019340addd0355eacce357a6b10a6a6a38819e9">apitest/scripts/rolling-offer-simulation.sh</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-bf66826ae6c033a94c8bb7f85bb7371d546246b086d9b8f8c2a9300cae7c75a6">apitest/scripts/trade-simulation.sh</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-91c37d56d8b392af4af818af8bbd61a217bc440afd89323a935cc83bba7dc769">apitest/src/main/java/bisq/apitest/ApiTestMain.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-4ddeb6572ceed22af58152ed079cd8948b1833ec48b9a9efa546c7c25693e147">apitest/src/main/java/bisq/apitest/Scaffold.java</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-536e343d77555cc6d8fda4de43d8eeb14833e73b1a9a8670cccdf14ce97f2367">apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-fe4eb748e73bb3dfd830fa64b52e0d1bf6f9d87fec57fd214217d4455ce2b294">apitest/src/main/java/bisq/apitest/linux/AbstractLinuxProcess.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-44d1f675626693524cb12d599245a09b4318db027c2dabd23e10cd98ceb7fd28">apitest/src/test/java/bisq/apitest/method/MethodTest.java</a>
(33)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-ad200ec31505b3e355063648a1187de23a0900e68d98e0b06efb37cc1e30485a">apitest/src/test/java/bisq/apitest/method/RegisterDisputeAgentsTest.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-c635a83c621d11fe469b4c85a89da2dc19300fd7048b1260d33cd5dc64ddd817">apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-e9afaf25a040818933ead2d35a47a8cfdbedfe645b5a20032150280683f6ddc0">apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java</a>
(6)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-a45f7c5244a8f5d570630c46ac64927e19aa18f1806470483af43b134f44f522">apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java</a>
(252)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-32b895cb27d0c846464892e61c9a57ac1d45a05eac0edcd53fd539ec89d2948e">apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java</a>
(101)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-95eb2e15e7182812f9c4518c5cbbb38d3c6fbb4ca8388f4600a5c1541ad29691">apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java</a>
(130)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-ca35fd2cf20069360ff48c6d99283c5fea8c929024ddbdfe44d60429da2a10a1">apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-c41ca392649706fed19bf13247aeab25d0aa4ec109c93691aa2e7839b0fea70d">apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java</a>
(52)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-23b8b2ec8bbf647b5e0144d2b67999c654ae12c9d8350ca7c13e1065e792096e">apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java</a>
(304)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-80fde285109a91d7581e771828393b6c87ac3b2a7e7de6ee750e7d41e594650a">apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java</a>
(51)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-a90c290d83f192163ef3343f9f0ed5f1f7f6de0e1b8f0d0ec3bf4cad5e61bbfb">apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java</a>
(309)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-0a94ee487ea9d0b7b440b8688f6e9df897fd089fc84ead5f6cc9ca9453ad3b21">apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java</a>
(57)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-a609d301c29b4d5cbf57988d0a292c2b1ca0ae61a80e564adc5d5b9937a6c33a">apitest/src/test/java/bisq/apitest/method/wallet/BtcTxFeeRateTest.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-9821c6377844d8a676dbeb322769c02a88430d0855752ea23a660b1dce2a9465">apitest/src/test/java/bisq/apitest/scenario/OfferTest.java</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-1d73b7115aba2f4d606e6ede4d563d83b6521e53a89c414a5086728076d1f51a">apitest/src/test/java/bisq/apitest/scenario/TradeTest.java</a>
(24)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-b4de23450b7705336f77c570c064b19161e2b637d3d77b7ebe2deec2ca9911bc">apitest/src/test/java/bisq/apitest/scenario/WalletTest.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-afc5db1c8acb08dec253ee87a3e0e677c932d6826a2ab4c31ba816a4dcfb1386">cli/src/main/java/bisq/cli/CliMain.java</a>
(23)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-ffe97abf7e2d3ee26d67dc41d7133233b29a92abc2b409a3406aed04380ff4ec">cli/src/main/java/bisq/cli/CryptoCurrencyUtil.java</a>
(35)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-bc03e9b04d52b37f48d4f56aa608b4a50a2085dff40f9fc738d910ea5a72d599">cli/src/main/java/bisq/cli/CurrencyFormat.java</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-ae5b5d0bb9a18998e885050698a2ce8dde809059fffc344f1d24a937e6ecbae3">cli/src/main/java/bisq/cli/GrpcClient.java</a>
(53)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-330baed45084180eea99af5e846a1c064bb8cebde98bcc24ad1c04d00efcb5b8">cli/src/main/java/bisq/cli/Method.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-94df640d5d04ce714b8032352a0581d03794e7eb058e867a7898389909b58d99">cli/src/main/java/bisq/cli/opts/CreatePaymentAcctOptionParser.java</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-f609ac828d29486bbf8bfac4cdb93aae89e327b6a5d3edea45d227e350e6ddc7">cli/src/main/java/bisq/cli/opts/VerifyBsqSentToAddressOptionParser.java</a>
(61)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-fb5876d3b212d239a14d78529ac498b30a2dbb8e3f184ba9bd711a5d4901fb62">core/src/main/java/bisq/core/api/CoreApi.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-f1df4fd99db45d9b91ec2a59f443619324e243cb5738a597ef8008b67cc97d9a">core/src/main/java/bisq/core/api/CoreWalletsService.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-1d2bf9ed9cc56f820a4ed2da95d5b6dedc345c4592134b4fab2c639e72bb2ae5">core/src/main/java/bisq/core/api/model/TxFeeRateInfo.java</a>
(6)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-1a2884ce38d4a0b32fbb02abe47fdf083190e8c257d4df716001e9082dfc74a6">core/src/main/resources/help/verifybsqsenttoaddress-help.txt</a>
(39)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-6d8b8c93482024d228b7265fa4533f5c1b9d2fc284f0e5e4c10f36d742f70dcb">daemon/src/main/java/bisq/daemon/grpc/GrpcPaymentAccountsService.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-2599dd16bc53cae95cd20c7466d22e1a79ae172db0526cd14f7839cee29ad9fe">daemon/src/main/java/bisq/daemon/grpc/GrpcWalletsService.java</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5421/files#diff-dcb44a0045a5b02cde5bd2f45051b7d9293f87180111c7ea57f0d0eb85d0f393">proto/src/main/proto/grpc.proto</a>
(1)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/5421.patch'>https://github.com/bisq-network/bisq/pull/5421.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/5421.diff'>https://github.com/bisq-network/bisq/pull/5421.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5421">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQK2I7SORYV4AU3D7TTJRE4VANCNFSM43GCRMVQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNV42WN2QLVMBLPLWTDTJRE4VA5CNFSM43GCRMV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4M2YUHTQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5421",
"url": "https://github.com/bisq-network/bisq/pull/5421",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>