<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5450#discussion_r623850115">core/src/main/java/bisq/core/btc/TxFeeEstimationService.java</a>:</p>
<pre style='color:#555'>> @@ -58,7 +58,7 @@
     public static int TYPICAL_TX_WITH_1_INPUT_VSIZE = 175;
     private static int DEPOSIT_TX_VSIZE = 233;
 
-    private static int BSQ_INPUT_INCREASE = 150;
+    private static int BSQ_INPUT_INCREASE = 65;
</pre>
<p>Indeed, so for now I think this is fine. It's also the taker that pays for the whole tx which makes even worse to get an accurate calculation.</p>
<p>Perhaps we should wait with this change and add in the next release when more BSQ utxos are segwit. If included right now it would guarantee to be wrong in the beginning.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5450#discussion_r623850115">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVWHHUSCGQGTQ7SSBTTLKRJFANCNFSM432TQ2TA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUGT4CM7NZBP6IJYETTLKRJFA5CNFSM432TQ2TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE2Y3A4I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5450#discussion_r623850115",
"url": "https://github.com/bisq-network/bisq/pull/5450#discussion_r623850115",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>