<p></p>
<p><b>@sqrrm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5450#discussion_r623708369">core/src/main/java/bisq/core/btc/TxFeeEstimationService.java</a>:</p>
<pre style='color:#555'>> @@ -58,7 +58,7 @@
     public static int TYPICAL_TX_WITH_1_INPUT_VSIZE = 175;
     private static int DEPOSIT_TX_VSIZE = 233;
 
-    private static int BSQ_INPUT_INCREASE = 150;
+    private static int BSQ_INPUT_INCREASE = 65;
</pre>
<p>I think this might be too low. I just had a look at this and the table I came up with was, to be on the safe side</p>
<p>Tx size:</p>
<table role="table">
<thead>
<tr>
<th>Element</th>
<th>size (vbyte)</th>
</tr>
</thead>
<tbody>
<tr>
<td>Overhead</td>
<td>10</td>
</tr>
<tr>
<td>Inputs</td>
<td>41 * N</td>
</tr>
<tr>
<td>Outputs</td>
<td>31 * N_sw + 34 * N_p2pkh</td>
</tr>
<tr>
<td>Sig p2pkh</td>
<td>108</td>
</tr>
<tr>
<td>Sig SW</td>
<td>29</td>
</tr>
</tbody>
</table>
<p>So I think the BSQ sw input should be counted as 41 + 29 = 70 vbytes extra, although it's sometimes a bit smaller.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5450#pullrequestreview-648998294">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXKAP66LPHTQAOP6G3TLJTJHANCNFSM432TQ2TA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNSU6Y7K5XE3L4IQY2TTLJTJHA5CNFSM432TQ2TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE2XO3FQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5450#pullrequestreview-648998294",
"url": "https://github.com/bisq-network/bisq/pull/5450#pullrequestreview-648998294",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>