<p></p>
<p><b>@chimp1984</b> requested changes on this pull request.</p>

<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/cd2357/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cd2357">@cd2357</a> Thanks for working on that.<br>
There is missing the chache update when a new block is added in <code>onNewBlockWithEmptyTxs</code>.<br>
Maybe its better to create explicit methods for <code>daoState.getBlocks().addAll</code> and <code>daoState.getBlocks().add</code> in DaoStateService.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5484#discussion_r631008211">core/src/main/java/bisq/core/dao/state/model/DaoState.java</a>:</p>
<pre style='color:#555'>> @@ -109,6 +109,8 @@ public static DaoState getClone(DaoState daoState) {
     @JsonExclude
     private transient final Map<String, Tx> txCache; // key is txId
     @JsonExclude
+    private transient final Map<Integer, Block> blockHeightCache; // key is block height
</pre>
<p>Maybe better name is blocksByHeight.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5484#pullrequestreview-657839939">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXLSLPZ7KDMBSFNHQDTNJ4VTANCNFSM44U225YQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUDP456O7SNRRHIPIDTNJ4VTA5CNFSM44U225Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE425OQY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5484#pullrequestreview-657839939",
"url": "https://github.com/bisq-network/bisq/pull/5484#pullrequestreview-657839939",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>