<p></p>
<p>Done, thanks for the speedy review.</p>
<blockquote>
<p>There is missing the chache update when a new block is added in <code>onNewBlockWithEmptyTxs</code>.<br>
Maybe its better to create explicit methods for <code>daoState.getBlocks().addAll</code> and <code>daoState.getBlocks().add</code> in DaoStateService.</p>
</blockquote>
<p>Good point. I restricted the adding of blocks to two new methods, <code>addBlock</code> and <code>addBlocks</code>. They make sure to update all the indices as well. Also made sure the <code>DaoState.blocks</code> list is not exposed directly anymore, but as an unmodifiable list, so no direct modifications are possible.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5484#issuecomment-841722955">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTHVSVRNSBTSKUILS3TN3MU5ANCNFSM44U225YQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRMGBPVAXRACI5XB7TTN3MU5A5CNFSM44U225Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGIV2YSY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5484#issuecomment-841722955",
"url": "https://github.com/bisq-network/bisq/pull/5484#issuecomment-841722955",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>