<p></p>
<p><b>@chimp1984</b> approved this pull request.</p>

<p>Beside the small naming issue utACK</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5484#discussion_r633161194">core/src/main/java/bisq/core/dao/state/model/DaoState.java</a>:</p>
<pre style='color:#555'>>      @JsonExclude
-    private transient final Set<String> blockHashCache;
+    private transient final Set<String> blocksByHash; // Blocks indexed by hash
</pre>
<p>With blocksByHash I would expect a map with hash as key and blocks as value. For a set I would use 'blockHashes'</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5484#pullrequestreview-660482841">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWLGVL5DB6JFY7SVKLTOBOQPANCNFSM44U225YQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNUFKSCRNA5SO4MFUMLTOBOQPA5CNFSM44U225Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE5PCWGI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5484#pullrequestreview-660482841",
"url": "https://github.com/bisq-network/bisq/pull/5484#pullrequestreview-660482841",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>