<p></p>
<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>NACK - Please see my comment regarding proto changes</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5500#discussion_r634441408">proto/src/main/proto/pb.proto</a>:</p>
<pre style='color:#555'>> +    string account_owner = 1;
+    string account_id = 2;
</pre>
<p>Never change the IDs of the old values, use incremented ones for new fields (<code>string account_owner=2</code>). This would cause issues with existing accounts. Please also run some backwards comp. tests with this change to be sure it works as expected.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5500#pullrequestreview-662165398">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTNJXY5L66O5DNYRJDTOJ25VANCNFSM45ACI4KA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNXYXW5GZCLURYJPVLDTOJ25VA5CNFSM45ACI4KKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE535PFQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5500#pullrequestreview-662165398",
"url": "https://github.com/bisq-network/bisq/pull/5500#pullrequestreview-662165398",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>