<p>This fix guarantees a callback if there is a pending request rather than just<br>
dropping the fee request.</p>
<p>When requestFee() is called the callbacks are added to a list of callBacks.<br>
Once the next fee request completes all callbacks in the list are called<br>
and the list cleared.</p>

<p>This issue popped up while testing atomic trades with the API and could likely be an issue for other usages of the API. If requestFees() is called while there is an pending request no callback is called. Since it's expected that either the resultHandler or the faultHandler is called it's not clear what happens for callers relying on the callbacks. This PR adds a guarantee one callback is called.</p>
<p>Also return early for the frequency check.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5528'>https://github.com/bisq-network/bisq/pull/5528</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add pending callbacks to FeeService</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5528/files#diff-04803da5fb51eabd94e0e0ca1ff8cf0cc7d39181abc242b1c3626b2c1b4546c3">core/src/main/java/bisq/core/provider/fee/FeeService.java</a>
    (113)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5528.patch'>https://github.com/bisq-network/bisq/pull/5528.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5528.diff'>https://github.com/bisq-network/bisq/pull/5528.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5528">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS6RVT3LLRACDKGICTTPOCJJANCNFSM45PEOONQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNS2RLO4UYUOEDO24C3TPOCJJA5CNFSM45PEOON2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4NNPFF5A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5528",
"url": "https://github.com/bisq-network/bisq/pull/5528",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>