<p>Added a new test class called PaymentAccountFactoryTest.java under bisq/core/src/test/java/bisq.core/payment</p>
<p>I noticed that there are currently no test cases for the PaymentAccountFactory, so I added some test cases to make sure the returned accounts are correct.</p>
<p>You will notice that there are some commented out PaymentMethods, these payment methods do not pass the test.</p>
<p>I noticed that the failing payment methods extend CountryBasedPaymentAccount, which is something to look into.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5530'>https://github.com/bisq-network/bisq/pull/5530</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>gpg test</li>
  <li>added PaymentAccountFactoryTest under bisq.core/test/payment</li>
  <li>Fixed PaymentAccountFactoryTest</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5530/files#diff-5d6967df6b713efe3ebd3143897d53693a82deb272dd8a3d6f47201c83c4c2fa">core/src/test/java/bisq/core/payment/PaymentAccountFactoryTest.java</a>
    (109)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5530.patch'>https://github.com/bisq-network/bisq/pull/5530.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5530.diff'>https://github.com/bisq-network/bisq/pull/5530.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5530">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNSNILOXSATJZ7NMPRLTPRZQRANCNFSM45QYNTLQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVRIWIQTJZZHADD2D3TPRZQRA5CNFSM45QYNTL2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4NN7M4DA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5530",
"url": "https://github.com/bisq-network/bisq/pull/5530",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>