<p></p>
<p><b>@KaiWitt</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5553#discussion_r646363334">common/src/main/java/bisq/common/config/Config.java</a>:</p>
<pre style='color:#555'>> @@ -124,6 +124,7 @@
     public static final String BTC_TX_FEE = "btcTxFee";
     public static final String BTC_MIN_TX_FEE = "btcMinTxFee";
     public static final String BTC_FEES_TS = "bitcoinFeesTs";
+    public static final String BTC_FEES_INFO = "bitcoinFeeInfo";
</pre>

⬇️ Suggested change
<pre style="color: #555">-    public static final String BTC_FEES_INFO = "bitcoinFeeInfo";
+    public static final String BTC_FEE_INFO = "bitcoinFeeInfo";
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5553#discussion_r646363700">pricenode/src/main/java/bisq/price/spot/ExchangeRateController.java</a>:</p>
<pre style='color:#555'>> +        Map<String, Object> feeInfo = feeRateService.getFees();
+        for (String key : feeInfo.keySet()) {
+            retVal.put(translateFieldName(key), feeInfo.get(key));
+        }
</pre>
<p>It's better to either iterate over <code>feeRateService.getFees().entrySet()</code> to avoid value lookups for each key and to make your intent clearer or use <code>feeRateService.getFees().forEach((k, v) -> ...)</code></p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5553#discussion_r646365575">pricenode/src/main/java/bisq/price/mining/FeeRateService.java</a>:</p>
<pre style='color:#555'>> +public
 class FeeRateService {
</pre>

⬇️ Suggested change
<pre style="color: #555">-public
-class FeeRateService {
+public class FeeRateService {
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5553#discussion_r646369990">pricenode/src/main/java/bisq/price/spot/ExchangeRateController.java</a>:</p>
<pre style='color:#555'>>      }
 
     @GetMapping(path = "/getAllMarketPrices")
     public Map<String, Object> getAllMarketPrices() {
-        return exchangeRateService.getAllMarketPrices();
+        Map<String, Object> retVal = exchangeRateService.getAllMarketPrices();
+
+        // add the fee info to results
+        Map<String, Object> feeInfo = feeRateService.getFees();
+        for (String key : feeInfo.keySet()) {
+            retVal.put(translateFieldName(key), feeInfo.get(key));
+        }
+
+        return retVal;
+    }
+
+    static String translateFieldName(String name) {
+        if (name.equals("dataMap"))
</pre>
<p><code>"dataMap"</code> should be a variable, as it is used across multiple methods</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5553#pullrequestreview-677108693">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNWHH4HMMCUKC5UMK2DTRR6QZANCNFSM46DJ4P6A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVM53GRXKH2CRQBDSLTRR6QZA5CNFSM46DJ4P6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFBN5XVI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5553#pullrequestreview-677108693",
"url": "https://github.com/bisq-network/bisq/pull/5553#pullrequestreview-677108693",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>