<p></p>
<p><b>@KaiWitt</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4081#discussion_r646417812">core/src/main/java/bisq/core/btc/setup/WalletsSetup.java</a>:</p>
<pre style='color:#555'>> +        var wellConfigured = isWellConfigured(versionMessage);
+        if (wellConfigured) {
</pre>
<p>A temp variable is not necessary imo, the method call is already very concise and readable</p>

⬇️ Suggested change
<pre style="color: #555">-        var wellConfigured = isWellConfigured(versionMessage);
-        if (wellConfigured) {
+        if (isWellConfigured(versionMessage)) {
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4081#discussion_r646422604">core/src/main/java/bisq/core/btc/setup/WalletsSetup.java</a>:</p>
<pre style='color:#555'>> +        if (wellConfigured) {
+            log.info("Peer well configured: {}", peer);
+        } else {
</pre>
<p>Redundant <code>else</code> clause bc the <code>if</code> can return. Makes it more readable</p>

⬇️ Suggested change
<pre style="color: #555">-        if (wellConfigured) {
-            log.info("Peer well configured: {}", peer);
-        } else {
+        if (wellConfigured) {
+            log.info("Peer well configured: {}", peer);
+            return;
+        }
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4081#pullrequestreview-677182177">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVGGWPU6JVC4TYGBTDTRSHPZANCNFSM4LQ7C2TA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNV6AVTFMWO6FPSBSETTRSHPZA5CNFSM4LQ7C2TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFBOPVYI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4081#pullrequestreview-677182177",
"url": "https://github.com/bisq-network/bisq/pull/4081#pullrequestreview-677182177",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>