<p></p>
<p><b>@dmos62</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/4081#discussion_r646593194">core/src/main/java/bisq/core/btc/setup/WalletsSetup.java</a>:</p>
<pre style='color:#555'>> +        var wellConfigured = isWellConfigured(versionMessage);
+        if (wellConfigured) {
</pre>
<p>A variable defining the condition is a style I use (and propagate) and, even if the called method is descriptive as well, I still use it. One reason is consistency of style. Another, the if statement doesn't care that the node being well configured is predicated on the version message (that's an implemenation detail), so there's no reason to put that in the if statement. I would be against your suggestion, because it optimizes for terseness at the cost of readability.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/4081#discussion_r646593194">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRXU3VKEXZZEM6D2ATTRTDKRANCNFSM4LQ7C2TA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVF74RHTY2V5O3AHZTTRTDKRA5CNFSM4LQ7C2TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFBQJP6A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/4081#discussion_r646593194",
"url": "https://github.com/bisq-network/bisq/pull/4081#discussion_r646593194",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>