<p></p>
<p><b>@KaiWitt</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5563#discussion_r650356461">desktop/src/main/java/bisq/desktop/components/ExplorerAddressTextField.java</a>:</p>
<pre style='color:#555'>> +    @Getter
+    private final TextField textField;
+    private final Label copyIcon, blockExplorerIcon, missingAddressWarningIcon;
+    @Setter
+    private boolean isBsq;
+
+
+    ///////////////////////////////////////////////////////////////////////////////////////////
+    // Constructor
+    ///////////////////////////////////////////////////////////////////////////////////////////
+
+    public ExplorerAddressTextField() {
+        copyIcon = new Label();
+        copyIcon.setLayoutY(3);
+        copyIcon.getStyleClass().addAll("icon", "highlight");
+        copyIcon.setTooltip(new Tooltip(Res.get("txIdTextField.copyIcon.tooltip")));
</pre>

⬇️ Suggested change
<pre style="color: #555">-        copyIcon.setTooltip(new Tooltip(Res.get("txIdTextField.copyIcon.tooltip")));
+        copyIcon.setTooltip(new Tooltip(Res.get("addressTextField.copyToClipboard")));
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5563#discussion_r650356772">desktop/src/main/java/bisq/desktop/components/ExplorerAddressTextField.java</a>:</p>
<pre style='color:#555'>> +    private boolean isBsq;
+
+
+    ///////////////////////////////////////////////////////////////////////////////////////////
+    // Constructor
+    ///////////////////////////////////////////////////////////////////////////////////////////
+
+    public ExplorerAddressTextField() {
+        copyIcon = new Label();
+        copyIcon.setLayoutY(3);
+        copyIcon.getStyleClass().addAll("icon", "highlight");
+        copyIcon.setTooltip(new Tooltip(Res.get("txIdTextField.copyIcon.tooltip")));
+        AwesomeDude.setIcon(copyIcon, AwesomeIcon.COPY);
+        AnchorPane.setRightAnchor(copyIcon, 30.0);
+
+        Tooltip tooltip = new Tooltip(Res.get("txIdTextField.blockExplorerIcon.tooltip"));
</pre>
<p>There is <code>tooltip.openBlockchainForAddress=Open external blockchain explorer for address: {0}</code> in displayStrings.properties, or maybe a new string is needed</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5563#discussion_r650356967">desktop/src/main/java/bisq/desktop/components/ExplorerAddressTextField.java</a>:</p>
<pre style='color:#555'>> +        AnchorPane.setRightAnchor(copyIcon, 30.0);
+
+        Tooltip tooltip = new Tooltip(Res.get("txIdTextField.blockExplorerIcon.tooltip"));
+
+        blockExplorerIcon = new Label();
+        blockExplorerIcon.getStyleClass().addAll("icon", "highlight");
+        blockExplorerIcon.setTooltip(tooltip);
+        AwesomeDude.setIcon(blockExplorerIcon, AwesomeIcon.EXTERNAL_LINK);
+        blockExplorerIcon.setMinWidth(20);
+        AnchorPane.setRightAnchor(blockExplorerIcon, 52.0);
+        AnchorPane.setTopAnchor(blockExplorerIcon, 4.0);
+
+        missingAddressWarningIcon = new Label();
+        missingAddressWarningIcon.getStyleClass().addAll("icon", "error-icon");
+        AwesomeDude.setIcon(missingAddressWarningIcon, AwesomeIcon.WARNING_SIGN);
+        missingAddressWarningIcon.setTooltip(new Tooltip(Res.get("txIdTextField.missingTx.warning.tooltip")));
</pre>
<p>needs a new dispay string, you're using a string for txIds</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5563#discussion_r650356980">desktop/src/main/java/bisq/desktop/components/ExplorerAddressTextField.java</a>:</p>
<pre style='color:#555'>> +        AnchorPane.setRightAnchor(missingAddressWarningIcon, 52.0);
+        AnchorPane.setTopAnchor(missingAddressWarningIcon, 4.0);
+        missingAddressWarningIcon.setVisible(false);
+        missingAddressWarningIcon.setManaged(false);
+
+        textField = new JFXTextField();
+        textField.setId("address-text-field");
+        textField.setEditable(false);
+        textField.setTooltip(tooltip);
+        AnchorPane.setRightAnchor(textField, 80.0);
+        AnchorPane.setLeftAnchor(textField, 0.0);
+        textField.focusTraversableProperty().set(focusTraversableProperty().get());
+        getChildren().addAll(textField, missingAddressWarningIcon, blockExplorerIcon, copyIcon);
+    }
+
+    public void setup(@Nullable String addressId) {
</pre>

⬇️ Suggested change
<pre style="color: #555">-    public void setup(@Nullable String addressId) {
+    public void setup(@Nullable String address) {
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5563#discussion_r650357191">desktop/src/main/java/bisq/desktop/components/ExplorerAddressTextField.java</a>:</p>
<pre style='color:#555'>> +    public static void setPreferences(Preferences preferences) {
+        ExplorerAddressTextField.preferences = preferences;
+    }
</pre>
<p>setters should be further down the file, after variable declarations and constructors</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5563#discussion_r650357427">desktop/src/main/java/bisq/desktop/components/ExplorerAddressTextField.java</a>:</p>
<pre style='color:#555'>> +        blockExplorerIcon.setOnMouseClicked(mouseEvent -> openBlockExplorer(addressId));
+        copyIcon.setOnMouseClicked(e -> Utilities.copyToClipboard(addressId));
+    }
+
+    public void cleanup() {
+        textField.setOnMouseClicked(null);
+        blockExplorerIcon.setOnMouseClicked(null);
+        copyIcon.setOnMouseClicked(null);
+        textField.setText("");
+    }
+
+    ///////////////////////////////////////////////////////////////////////////////////////////
+    // Private
+    ///////////////////////////////////////////////////////////////////////////////////////////
+
+    private void openBlockExplorer(String addressId) {
</pre>

⬇️ Suggested change
<pre style="color: #555">-    private void openBlockExplorer(String addressId) {
+    private void openBlockExplorer(String address) {
</pre>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5563#pullrequestreview-682302956">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXDQSKMU3DBNVJNMELTSMBWJANCNFSM46O3VLGA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRS7SJFWANMNSKJIQ3TSMBWJA5CNFSM46O3VLGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFCVR33A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5563#pullrequestreview-682302956",
"url": "https://github.com/bisq-network/bisq/pull/5563#pullrequestreview-682302956",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>