<p>To help review from bottom to top, commits are listed here in bottom to top order.</p>
<ul>
<li>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/1daf4715f843acdd816c90ee9ae0bf5aaf630a93/hovercard" href="https://github.com/bisq-network/bisq/commit/1daf4715f843acdd816c90ee9ae0bf5aaf630a93"><tt>1daf471</tt></a> Add <code>OfferInfo</code> field <code>isActivated</code>, rpc <code>EditOffer</code> to <code>grpc.proto</code></p>
</li>
<li>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/2b8b53bba86579d71e184aac38531e15f462084b/hovercard" href="https://github.com/bisq-network/bisq/commit/2b8b53bba86579d71e184aac38531e15f462084b"><tt>2b8b53b</tt></a> Add server/core <code>editOffer</code>, adjust<code> getMyOffer(s)</code> impls<br>
Add <code>editOffer</code> to <code>GrpcOffersService</code>, <code>CoreApi</code>, <code>CoreOffersService</code>.<br>
Set <code>editOffer</code> call rate meter to 1 / minute.<br>
Use new <code>EditOfferValidator</code> to verify <code>editOffer</code> params OK.<br>
Adust <code>getMyOffer(s)</code> rpc impl and <code>OfferInfo</code> model to use <code>OpenOffer</code> for accessing activation state and trigger price.</p>
</li>
<li>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/9231e48c439debc44213132e4b3a7f540503cad0/hovercard" href="https://github.com/bisq-network/bisq/commit/9231e48c439debc44213132e4b3a7f540503cad0"><tt>9231e48</tt></a> Refactor GrpcClient: request building code moved into <code>bisq.cli.request</code> pkg<br>
Reduces size of <code>GrpcClient</code> while allowing for new, bot-friendly variations of the new grpc.editOffer method. (Various combinations of <code>editoffer</code> parameters are allowed and disallowed; the bot-friendly grpc.editOffer variations help disambiguate those parameter combinations.)</p>
</li>
<li>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/d2939cc5676ce840d6af771d0321b0ffe2579b7c/hovercard" href="https://github.com/bisq-network/bisq/commit/d2939cc5676ce840d6af771d0321b0ffe2579b7c"><tt>d2939cc</tt></a> Add new <code>EditOfferOptionParser</code> & test</p>
</li>
<li>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/2344285ed3d7afd098a2bcc5920d8e5083720d88/hovercard" href="https://github.com/bisq-network/bisq/commit/2344285ed3d7afd098a2bcc5920d8e5083720d88"><tt>2344285</tt></a> Add <code>editoffer</code> method help</p>
</li>
<li>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/be249c5e795065c627afe320cd9aa01ab2121894/hovercard" href="https://github.com/bisq-network/bisq/commit/be249c5e795065c627afe320cd9aa01ab2121894"><tt>be249c5</tt></a> Add <code>editoffer</code> to CLI</p>
</li>
<li>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/bisq-network/bisq/commit/929b28cb8cb1667f0d64d3eb1bd017e56ee2d37a/hovercard" href="https://github.com/bisq-network/bisq/commit/929b28cb8cb1667f0d64d3eb1bd017e56ee2d37a"><tt>929b28c</tt></a> Add <code>editoffer</code> api tests & minor apitest refactoring</p>
</li>
</ul>
<p>This is the 3rd in a series of PRs, starting at <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="919660295" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5570" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5570/hovercard" href="https://github.com/bisq-network/bisq/pull/5570">#5570</a><br>
<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="919667993" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5571" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5571/hovercard" href="https://github.com/bisq-network/bisq/pull/5571">#5571</a> Should be reviewed/merged before this one.</p>
<p>The new <code>editoffer</code> method works, and is documented in <code>editoffer-help.txt</code>, but some follow up work is needed.<br>
Next PR(s) will be:</p>
<ul>
<li>Adjust <code>getmyoffer(s)</code> CLI output for new '<code>enabled</code>' and '<code>trigger-price</code>' columns.</li>
<li>Adjust apitest trading scripts to new <code>getmyoffer(s) </code>CLI output.</li>
<li>Adjust apitest user guide for new <code>editoffer</code>, and to new <code>getmyoffer(s)</code> CLI output.</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/5572'>https://github.com/bisq-network/bisq/pull/5572</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Remove commented out test</li>
<li>Remove unsupported create CHASE_QUICK_PAY apitest case</li>
<li>Refactor EditOfferDataModel for new editoffer api method</li>
<li>Fix comment</li>
<li>Add OfferInfo field isActivated, rpc EditOffer to proto</li>
<li>Add server/core editOffer, adjust getMyOffer(s) impls</li>
<li>Refactor GrpcClient: request builders moved bisq.cli.request pkg</li>
<li>Add new EditOfferOptionParser and test</li>
<li>Add editoffer method help</li>
<li>Add editoffer to CLI</li>
<li>Add editoffer api tests & minor apitest refactoring</li>
<li>Remove chase quickpay acct test</li>
<li>Remove unused import</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-c635a83c621d11fe469b4c85a89da2dc19300fd7048b1260d33cd5dc64ddd817">apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java</a>
(50)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-e9afaf25a040818933ead2d35a47a8cfdbedfe645b5a20032150280683f6ddc0">apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-95eb2e15e7182812f9c4518c5cbbb38d3c6fbb4ca8388f4600a5c1541ad29691">apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java</a>
(70)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-c509b6ac7a6e233bdce7b899a481d6f2d310495356be8025e8296481bca6decb">apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java</a>
(429)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-98766e3307ebb6c5e165c4538df5e46fc1d8e8abf81f66771fcfc5bbb6408131">apitest/src/test/java/bisq/apitest/method/payment/CreatePaymentAccountTest.java</a>
(23)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-80fde285109a91d7581e771828393b6c87ac3b2a7e7de6ee750e7d41e594650a">apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-0a94ee487ea9d0b7b440b8688f6e9df897fd089fc84ead5f6cc9ca9453ad3b21">apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java</a>
(3)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-8ec418fbbeef108d5131d09db3e2d6a399900e03c90578db7d8685f73ab88c61">apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java</a>
(167)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-9821c6377844d8a676dbeb322769c02a88430d0855752ea23a660b1dce2a9465">apitest/src/test/java/bisq/apitest/scenario/OfferTest.java</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-ddf4721374613fe047631b685717fbcaf3c0dd687db70b0f5d7d9150b3affdb5">apitest/src/test/java/bisq/apitest/scenario/PaymentAccountTest.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-f661c3bd0385dafccef63c304b78674c5e3e1305f663885c97daf05bf6ad6257">apitest/src/test/java/bisq/apitest/scenario/bot/BotClient.java</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-7fdd0ca2025f77ccbebb1cd6636ce3b348793ac7d35aaaed30f2bc8edc53d74d">apitest/src/test/java/bisq/apitest/scenario/bot/RandomOffer.java</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-afc5db1c8acb08dec253ee87a3e0e677c932d6826a2ab4c31ba816a4dcfb1386">cli/src/main/java/bisq/cli/CliMain.java</a>
(42)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-bc03e9b04d52b37f48d4f56aa608b4a50a2085dff40f9fc738d910ea5a72d599">cli/src/main/java/bisq/cli/CurrencyFormat.java</a>
(63)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-ae5b5d0bb9a18998e885050698a2ce8dde809059fffc344f1d24a937e6ecbae3">cli/src/main/java/bisq/cli/GrpcClient.java</a>
(377)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-330baed45084180eea99af5e846a1c064bb8cebde98bcc24ad1c04d00efcb5b8">cli/src/main/java/bisq/cli/Method.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-81d1e9d20597797e7e7362edb885afae00c219a7b9ad04167c265945adc767c3">cli/src/main/java/bisq/cli/opts/AbstractMethodOptionParser.java</a>
(4)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-be7c0421fc919918d0ef150748a177731e56d8754ce45ba09070c6a28b7652bb">cli/src/main/java/bisq/cli/opts/EditOfferOptionParser.java</a>
(264)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-c3491a41f640da451ad42a12869b1f6552f22c2fb56da31eeb1c01498a8b8203">cli/src/main/java/bisq/cli/opts/OptLabel.java</a>
(2)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-4e8c0dfbccf8d462e6d9b506f60ec6a0fcf6ec6d948a830a0319f535b6273a68">cli/src/main/java/bisq/cli/request/OffersServiceRequest.java</a>
(317)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-4d8e7b98c8ea2d4c217008f86c97a1f65cf138557745bd52474c38d4386b971f">cli/src/main/java/bisq/cli/request/PaymentAccountsServiceRequest.java</a>
(85)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-ad3170ab7cde237c109c2a6976774bb1ef54a9b597c0e40dc01ab505e0c25f62">cli/src/main/java/bisq/cli/request/TradesServiceRequest.java</a>
(94)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-5ea9c900e9b8b10fab66da64476b82fa79faab0bdc6dfccf9a5238c2fc44a9b8">cli/src/main/java/bisq/cli/request/WalletsServiceRequest.java</a>
(192)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-a7c731229ae8471ee510164ce23fd5d16e0242a3de5c982ae0c3e04d9a20f962">cli/src/test/java/bisq/cli/opt/EditOfferOptionParserTest.java</a>
(325)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-89bd90c4f1800a87fb80e3ec2076b5cecb78b4f3d681a657eccce55a486e8e04">cli/src/test/java/bisq/cli/opt/OptionParsersTest.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-fb5876d3b212d239a14d78529ac498b30a2dbb8e3f184ba9bd711a5d4901fb62">core/src/main/java/bisq/core/api/CoreApi.java</a>
(43)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-e66126b732dbd45cde04307641186caa214407bc74403812b10d3ebf18d2aecc">core/src/main/java/bisq/core/api/CoreOffersService.java</a>
(156)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-410e4a9ca8e6f5e3cfdd5c062c19512e63fa38a82b1247f91ef29ed385f34d1b">core/src/main/java/bisq/core/api/EditOfferValidator.java</a>
(135)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-3a9ff7695726e0660444b5b5e18600d2cff2bc2fcdf3f78c36a0fc3df504e1b6">core/src/main/java/bisq/core/api/model/OfferInfo.java</a>
(22)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-097028e83b2494ec6c56ccd77cb7aadadcbdc179233003a99605bd02ab3f76af">core/src/main/java/bisq/core/offer/MutableOfferPayloadFields.java</a>
(89)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-b604ee7141fcfacf2dd0aeade4bf393c4d4d93617ab327147c363539ae804496">core/src/main/java/bisq/core/offer/OfferUtil.java</a>
(47)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-8117d541d1fe0e9008d17a7cb5c9b944c83e92c280748e5ef6de5c057a355e3c">core/src/main/resources/help/editoffer-help.txt</a>
(95)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-0f99ad2cb9a6db1e6196b198ef915e473e6eafa8c7afc61ddfe5f33085e11423">core/src/test/java/bisq/core/payment/PaymentAccountsTest.java</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-5afef68b74948ae40e71a3955d52c1bfd52fa4a95fed271c6cae61626089073d">daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java</a>
(30)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-41b34a44d2df26644ec2e93e7c7211540603530d5d8649b0545ec4963b5315d5">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java</a>
(49)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5572/files#diff-dcb44a0045a5b02cde5bd2f45051b7d9293f87180111c7ea57f0d0eb85d0f393">proto/src/main/proto/grpc.proto</a>
(32)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/5572.patch'>https://github.com/bisq-network/bisq/pull/5572.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/5572.diff'>https://github.com/bisq-network/bisq/pull/5572.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5572">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQ3OR5GK6SDKP7LIATTSTMZPANCNFSM46T4TZTA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTKTCFXEYZBGG6H5STTSTMZPA5CNFSM46T4TZTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4NWTSSPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5572",
"url": "https://github.com/bisq-network/bisq/pull/5572",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>