<p></p>
<p><b>@KaiWitt</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/5571#discussion_r650499856">core/src/main/java/bisq/core/offer/OfferUtil.java</a>:</p>
<pre style='color:#555'>> + // Returns an edited payload: a merge of the original offerPayload and
+ // editedOfferPayload fields. Mutable fields are sourced from
+ // mutableOfferPayloadFields param, e.g., payment account details, price, etc.
+ // Immutable fields are sourced from the original openOffer param.
</pre>
<p>JavaDoc or it doesn't show up in the documentation popup in your IDE</p>
⬇️ Suggested change
<pre style="color: #555">- // Returns an edited payload: a merge of the original offerPayload and
- // editedOfferPayload fields. Mutable fields are sourced from
- // mutableOfferPayloadFields param, e.g., payment account details, price, etc.
- // Immutable fields are sourced from the original openOffer param.
+ /**
+ * Returns an edited payload: a merge of the original offerPayload and
+ * editedOfferPayload fields. Mutable fields are sourced from
+ * mutableOfferPayloadFields param, e.g., payment account details, price, etc.
+ * Immutable fields are sourced from the original openOffer param.
+ */
</pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5571#pullrequestreview-682391610">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNU6IUVHBJLL6WPHUBLTSR5MRANCNFSM46TDL35Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTDN5OJRPKZYNMML33TSR5MRA5CNFSM46TDL352YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFCWHQOQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5571#pullrequestreview-682391610",
"url": "https://github.com/bisq-network/bisq/pull/5571#pullrequestreview-682391610",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>