<p></p>
<p><b>@ripcurlx</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5563#discussion_r653587352">desktop/src/main/java/bisq/desktop/components/ExplorerAddressTextField.java</a>:</p>
<pre style='color:#555'>> +    public static void setPreferences(Preferences preferences) {
+        ExplorerAddressTextField.preferences = preferences;
+    }
</pre>
<blockquote>
<p><code>preferences</code> is static field, not sure why - I used same approach like in <code>TxIdTextField</code></p>
</blockquote>
<p>Yes it is true that it is right now the same as in TxIdTextField, but I also would prefer using the <a class="user-mention" data-hovercard-type="organization" data-hovercard-url="/orgs/Setter/hovercard" href="https://github.com/Setter">@Setter</a> annotation and getting rid of the unnecessary setPreferences method.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5563#discussion_r653587352">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRWDIE75PIJZNJE7ULTTH455ANCNFSM46O3VLGA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNVN3CRVL737A5HA7CTTTH455A5CNFSM46O3VLGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFDULMMI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5563#discussion_r653587352",
"url": "https://github.com/bisq-network/bisq/pull/5563#discussion_r653587352",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>