<p>Reported by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/huey735/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/huey735">@huey735</a> there is a display bug when chat messages are stored in mailbox awaiting peer to come online.<br>
The bug was introduced by <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="909612267" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5551" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5551/hovercard" href="https://github.com/bisq-network/bisq/pull/5551">#5551</a><br>
The fix is to consider both acknowledged and stored in mailbox statuses when checking if the message timed out.</p>
<p>To reproduce:</p>
<ul>
<li>Alice sends chat message to Bob (who is offline).</li>
<li>Alice's chat window shows <code>Message saved in receiver's mailbox</code>.</li>
<li>Alice closes chat window, and reopens it again.</li>
<li>Alice's chat window now says <code>Error: timed out.  Try sending message again</code>.   << This is the bug.</li>
</ul>
<p>Expected behavior:</p>
<ul>
<li>Alice sends chat message to Bob (who is offline).</li>
<li>Alice's chat window shows <code>Message saved in receiver's mailbox</code>.</li>
<li>Alice closes chat window, and reopens it again.</li>
<li>Alice's chat window shows <code>Message saved in receiver's mailbox</code>.</li>
</ul>
<p>If Bob were to come online Alice's window would update to <code>Message arrival confirmed by receiver</code>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5599'>https://github.com/bisq-network/bisq/pull/5599</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>fix bug in chatmessage timeout status</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5599/files#diff-ddfedfeef385bf2139279ae3e517cd3c4dd83308de409c3d6d56a31698dfba52">core/src/main/java/bisq/core/support/messages/ChatMessage.java</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5599.patch'>https://github.com/bisq-network/bisq/pull/5599.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5599.diff'>https://github.com/bisq-network/bisq/pull/5599.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5599">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVY5ZSQTN6FAH4JIKLTVXCCVANCNFSM47WZQKVA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNTPFJBMRJJUYAB4RDDTVXCCVA5CNFSM47WZQKVKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4N6HIUTQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5599",
"url": "https://github.com/bisq-network/bisq/pull/5599",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>