<p><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="935806247" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5599" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5599/hovercard" href="https://github.com/bisq-network/bisq/pull/5599">#5599</a> had an side effect that did not manifest until tested on mainnet (with tor, latency etc).</p>
<p>Chat message status was not picked up by the display, even if it was set correctly on the object (scrolling up and down on the chat box would update the display to correct status).  This happened because the ChatView stopped listening for updates prematurely.  Changed it to wait for acknowledged status instead of arrived status.</p>
<p>The timeout for displaying a <code>Try sending message again</code> error message had to be increased from 5 seconds to 60.  In mainnet it routinely takes 7 - 16 seconds to open a tor connection so the try again message was being shown all the time unless a connection was already established.  60 seconds gives enough time for the message to be acked, or saved to mailbox.  Then only the rare outliers should get the try again message when the message apparently arrives but is not acked (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="900220401" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5526" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/5526/hovercard" href="https://github.com/bisq-network/bisq/issues/5526">#5526</a>).</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5632'>https://github.com/bisq-network/bisq/pull/5632</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>keep chatview listener open until ack, mailbox, or error</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5632/files#diff-ddfedfeef385bf2139279ae3e517cd3c4dd83308de409c3d6d56a31698dfba52">core/src/main/java/bisq/core/support/messages/ChatMessage.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5632/files#diff-63cad11c070fee7154615affe7949f75b0b47e394dbafde0b441f79cdc64fe92">desktop/src/main/java/bisq/desktop/main/shared/ChatView.java</a>
    (21)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5632.patch'>https://github.com/bisq-network/bisq/pull/5632.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5632.diff'>https://github.com/bisq-network/bisq/pull/5632.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5632">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNXW7T6G7J3KJCL5533TZDXDVANCNFSM5A3I44OQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRUX6VZM6V3WT2FLCLTZDXDVA5CNFSM5A3I44O2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OFS2UGA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5632",
"url": "https://github.com/bisq-network/bisq/pull/5632",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>