<p>Problem: Negative mining fees could be shown in the make/take offer summary popup when BSQ is used for fees and the BTC sats value of the BSQ is greater than the calculated transaction fee.</p>
<p>Using BSQ to pay trade fees burns the BSQ effectively paying miners with those sats.  A bug surfaced whereby negative mining fees could be displayed, giving a false/confusing impression to users.  Note that this is a display issue only, there were no problems with the trading transactions themselves.</p>
<p>After this fix, the displayed mining fee cannot be negative.</p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/127591622-c5285a1a-dba9-4d8c-8fd9-3105b073e329.png"><img src="https://user-images.githubusercontent.com/47253594/127591622-c5285a1a-dba9-4d8c-8fd9-3105b073e329.png" alt="image" style="max-width:100%;"></a></p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/127591331-70e7580b-0048-4e48-8547-8b927f96a0b4.png"><img src="https://user-images.githubusercontent.com/47253594/127591331-70e7580b-0048-4e48-8547-8b927f96a0b4.png" alt="Screenshot from 2021-07-29 21-34-53" style="max-width:100%;"></a></p>
<p>In these examples the BSQ fee rate (Param.java) was artificially increased to 100 BSQ/BTC producing larger than usual BSQ fees and triggering the bug in order to validate the fix.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5643'>https://github.com/bisq-network/bisq/pull/5643</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>prevent negative suggested mining fee when burning BSQ for fees</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5643/files#diff-3cf8bddee5a7364f6e0018392f074e94107ee04a145a51dec551b6b7145002f6">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5643/files#diff-e91ddc497f0b94a9a80cc234cbdcedaf05e8f40e6e1d5fc7e9c9794f97063495">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java</a>
    (11)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5643.patch'>https://github.com/bisq-network/bisq/pull/5643.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5643.diff'>https://github.com/bisq-network/bisq/pull/5643.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5643">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQRGXZOVPYLSCKQ6SDT2IHBJANCNFSM5BHUOKIQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AJFFTNRQG2JL5LGLU2Q33KLT2IHBJA5CNFSM5BHUOKI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OIAYOQQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5643",
"url": "https://github.com/bisq-network/bisq/pull/5643",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>