<p>Reported by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/stakoholic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/stakoholic">@stakoholic</a>, when editing an offer some information was not being transferred.</p>
<p><code>extraData</code> is used for the account age and other custom fields like F2F city.<br>
So when editing an offer the extraData should be obtained from the edited offer not the original one.</p>
<p><span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #5597.">Fixes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="935072197" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5597" data-hovercard-type="issue" data-hovercard-url="/bisq-network/bisq/issues/5597/hovercard" href="https://github.com/bisq-network/bisq/issues/5597">#5597</a><br>
FYI <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ghubstan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ghubstan">@ghubstan</a> this one line fix also needs carrying over to the current editoffer API work.</p>
<hr>
<h3>Testing:</h3>
<p>You have an Amazon gift card account which is 4 days old (for example).<br>
Create an F2F account which specifies city as 'Paris' and additional information as "ask for Freddie".</p>
<p><strong>Prior version: (bug)</strong></p>
<ul>
<li>Create offer to buy 0.01 BTC using Amazon gift card.</li>
<li>Edit the offer changing payment account to F2F.</li>
<li>Look at the offer in the order book.</li>
<li>It should show the F2F city ('Paris') but it is blank.</li>
<li>It should show additional information ("ask for Freddie") but it is blank.</li>
<li>It should show the account age as 0 days old but instead shows it as 4 days old.</li>
</ul>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/127954270-f07c9a5e-7a61-413a-a9f0-5d07862afbe8.png"><img src="https://user-images.githubusercontent.com/47253594/127954270-f07c9a5e-7a61-413a-a9f0-5d07862afbe8.png" alt="image" style="max-width:100%;"></a></p>
<p><strong>Version with fix applied:</strong></p>
<ul>
<li>Create offer to buy 0.01 BTC using Amazon gift card.</li>
<li>Edit the offer changing payment account to F2F.</li>
<li>Look at the offer in the order book.</li>
<li>It shows the F2F city ('Paris').</li>
<li>It shows additional information as "ask for Freddie".</li>
<li>It shows the account age as 0 days old.</li>
</ul>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/47253594/127954784-02871aa6-c90c-4565-8e78-50d01ca91446.png"><img src="https://user-images.githubusercontent.com/47253594/127954784-02871aa6-c90c-4565-8e78-50d01ca91446.png" alt="image" style="max-width:100%;"></a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/5651'>https://github.com/bisq-network/bisq/pull/5651</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>fix issue with extraData field when editing offer</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/5651/files#diff-41b34a44d2df26644ec2e93e7c7211540603530d5d8649b0545ec4963b5315d5">desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/5651.patch'>https://github.com/bisq-network/bisq/pull/5651.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/5651.diff'>https://github.com/bisq-network/bisq/pull/5651.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5651">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNS3PLUHRUQHFDZDP4DT25SPTANCNFSM5BN7E33A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email">Android</a>.<img src="https://github.com/notifications/beacon/AJFFTNSW27UBPZAK75H6RWLT25SPTA5CNFSM5BN7E33KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OJERJRA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5651",
"url": "https://github.com/bisq-network/bisq/pull/5651",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>