<p>This is the 2nd in a series of PRs starting with <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="989293984" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5685" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5685/hovercard" href="https://github.com/bisq-network/bisq/pull/5685">#5685</a>.<br>
<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="989293984" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/5685" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/5685/hovercard" href="https://github.com/bisq-network/bisq/pull/5685">#5685</a> should be reviewed & merged before this one.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/5687'>https://github.com/bisq-network/bisq/pull/5687</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Wrap long i18n strings for use in API</li>
<li>Format comments, add one</li>
<li>Replace growing # of instanceof checks with boolean hasPaymentMethodWithId</li>
<li>Adjust to PaymentAccount changes in commit de23fc0</li>
<li>Do single trade currency check in api generated payment acct</li>
<li>Adjust to PaymentAccount change in commit de23fc0</li>
<li>Let users specify trade ccys and selected trade ccy in json form</li>
<li>Do pay acct ccy checks, add tests, anticipate swift pay method</li>
<li>Remove spurious `PaymentAccount#canSupportMultipleCurrencies()`</li>
<li>Set apitest test case log level to INFO</li>
<li>Define toString method</li>
<li>Adjust for XMR support</li>
<li>Refactor for supporting creation of XMR accounts via API</li>
<li>Refactor for supporting creation of XMR accounts via API</li>
<li>Add create bsq & xmr payment acct test cases</li>
<li>Don't run method test 2x from gradle</li>
<li>Merge branch 'master' into 2-create-xmr-payment-accts-via-api</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-536e343d77555cc6d8fda4de43d8eeb14833e73b1a9a8670cccdf14ce97f2367">apitest/src/main/java/bisq/apitest/config/ApiTestConfig.java</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-44d1f675626693524cb12d599245a09b4318db027c2dabd23e10cd98ceb7fd28">apitest/src/test/java/bisq/apitest/method/MethodTest.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-8efa98a721b8ec574d3856b9ba9df31a5df2fd9d1c7d37efbcc6bdc20b3c2b3b">apitest/src/test/java/bisq/apitest/method/payment/AbstractPaymentAccountTest.java</a>
(114)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-98766e3307ebb6c5e165c4538df5e46fc1d8e8abf81f66771fcfc5bbb6408131">apitest/src/test/java/bisq/apitest/method/payment/CreatePaymentAccountTest.java</a>
(290)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-ddf4721374613fe047631b685717fbcaf3c0dd687db70b0f5d7d9150b3affdb5">apitest/src/test/java/bisq/apitest/scenario/PaymentAccountTest.java</a>
(14)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-c022883cbf9c5e95c8a4611017c985077547bbd6e5a11192134262c130363c45">apitest/src/test/resources/logback.xml</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-afc5db1c8acb08dec253ee87a3e0e677c932d6826a2ab4c31ba816a4dcfb1386">cli/src/main/java/bisq/cli/CliMain.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-ffe97abf7e2d3ee26d67dc41d7133233b29a92abc2b409a3406aed04380ff4ec">cli/src/main/java/bisq/cli/CryptoCurrencyUtil.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-5bbbcb4ac606dd02df87723eb68c37ad7e3a6f09d8aa307f363bec7e33e74564">cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-ede07c8bd4b1fa3a239f204d2755a98f4aa7169b6acda7d2acebc2e6f9e0cf05">cli/src/test/java/bisq/cli/opts/OptionParsersTest.java</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-954a13a40a21444790276f14d9f6d3b436d9a25407c63649f035fcf6368c12cd">common/src/main/java/bisq/common/util/Utilities.java</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-161be9419f5c0abf3098d8ac7d8b096a321bb76f0c26b5be11cc183958209368">core/src/main/java/bisq/core/api/CorePaymentAccountsService.java</a>
(58)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-f1df4fd99db45d9b91ec2a59f443619324e243cb5738a597ef8008b67cc97d9a">core/src/main/java/bisq/core/api/CoreWalletsService.java</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-0ee6d746cd6c9f47730564789acdbc817a021fae26cf38fc1493c03e61ac0270">core/src/main/java/bisq/core/api/model/PaymentAccountForm.java</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-51eee6356fda3d54c9fdf17f0d40df2bd8fbaec835183ef02f45416e6ff37d75">core/src/main/java/bisq/core/api/model/PaymentAccountTypeAdapter.java</a>
(141)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-fb6166c0626cd91feee227e7f33f4c3a9e43b88c9ee0473c59db5cbebd1c74ad">core/src/main/java/bisq/core/locale/Res.java</a>
(28)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-1dd9914e3d0450d8cc1aaa2f15afa9836051911a41ecb287a813f9cd4f9f5afd">core/src/main/java/bisq/core/offer/CreateOfferService.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-189dabf054a26f4cd086890f538252d6c47a246491d7d95e730ce6a0e640d786">core/src/main/java/bisq/core/payment/PaymentAccount.java</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-339f5d90e0409e9cf2decfeb87c5d1ef65b96d4db89e226f600d93c3b6a62823">core/src/main/java/bisq/core/payment/payload/AssetsAccountPayload.java</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-68a0fcdcf30bce675a1c87cc2bc1c384b2b382389dc974f1e550311e75a9659b">core/src/main/resources/help/createcryptopaymentacct-help.txt</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-3cf8bddee5a7364f6e0018392f074e94107ee04a145a51dec551b6b7145002f6">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferDataModel.java</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-a110b4dbf593eb67e3a80e59506f58cd95ddbf8fe983bf3d967d8bbe2c8471fe">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-6be5a2a3e9efad426d4520445826d641b9e78a901f8120af6c528cced19a0587">desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java</a>
(31)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-e91ddc497f0b94a9a80cc234cbdcedaf05e8f40e6e1d5fc7e9c9794f97063495">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferDataModel.java</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5687/files#diff-574ce6bfa753de6de705ba360ded021a7a94dcc406ad740c009483f3a2effae7">desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java</a>
(14)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/5687.patch'>https://github.com/bisq-network/bisq/pull/5687.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/5687.diff'>https://github.com/bisq-network/bisq/pull/5687.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5687">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNUZ3BSA7F2LUNEMHJ3UBE62HANCNFSM5DYFONTA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AJFFTNR634N577BMLNBJGW3UBE62HA5CNFSM5DYFONTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OZL72FQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5687",
"url": "https://github.com/bisq-network/bisq/pull/5687",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>