<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ripcurlx/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> Yeah, you're right. I wish I had more time. The code change itself is looking good. While double-checking I noticed some other unimportant issues around there, though everything works fine as-is.</p>
<ol>
<li>
<p>These two lines are almost identical and so mostly redundant:<br>
<code>"ぁ-ゔ" + // full-width hiragana (0x3041 ~ 0x3094)</code><br>
<code>"ぁ-ゞ" + // half-width hiragana</code> (0x3041 ~ 0x309e)<br>
One could simplify the above two lines as one line:<br>
<code>"ぁ-ゞ" + // hiragana (0x3041 ~ 0x309e)</code><br>
Note, Unicode hiragana is always full-width, there's no "half-width hiragana" afaik.</p>
</li>
<li>
<p>The comment is incorrect in this line, which includes 5 code points, not 4:<br>
<code>"ヽヾ゛゜ー" + // 0x309e, 0x309b, 0x309c, 0x30fc</code><br>
The first two code points are:<br>
U+30FD [ ヽ ] KATAKANA ITERATION MARK<br>
U+30FE [ ヾ ] KATAKANA VOICED ITERATION MARK<br>
So you can change <code>0x309e</code> to <code>0x30fd, 0x30fe</code>. The other three (<code>0x309b, 0x309c, 0x30fc</code>) are fine as-is.</p>
</li>
</ol>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/5688#issuecomment-918244412">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNTCFKEEV4RPBQJ6DTTUBYCJRANCNFSM5DYT57NA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AJFFTNQH65IFFIFIW2Y4C5DUBYCJRA5CNFSM5DYT57NKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG25UYPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/5688#issuecomment-918244412",
"url": "https://github.com/bisq-network/bisq/issues/5688#issuecomment-918244412",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>