<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/xyzmaker123/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/xyzmaker123">@xyzmaker123</a> Thanks for your PR. Just a couple of remarks on the UI Code. Please try to use the AutoTooltip... components instead of the JFX.. default ones. So it will automatic truncate and provide a tooltip if a translation won't fit into the boundaries. The other thing is we try to not use FXML syntax whenever possible as it is bad for performance. So we normally just have a main container as an entry point and instantiate all other UI components manually. And yes, there are still some legacy FXML UIs (network..) out there which would need some dev love. <g-emoji class="g-emoji" alias="wink" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f609.png">😉</g-emoji></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5680#issuecomment-917922723">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNVEECXTER72QP5OI2DUBWSZNANCNFSM5DCTWNVQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AJFFTNWTW2VQBRJIORCBZJ3UBWSZNA5CNFSM5DCTWNV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG23GHIY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5680#issuecomment-917922723",
"url": "https://github.com/bisq-network/bisq/pull/5680#issuecomment-917922723",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>