<ul class="contains-task-list">
<li class="task-list-item">
<p><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> <strong>PayTM</strong><br>
<span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #226.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="792624039" data-permission-text="Title is private" data-url="https://github.com/bisq-network/growth/issues/226" data-hovercard-type="issue" data-hovercard-url="/bisq-network/growth/issues/226/hovercard" href="https://github.com/bisq-network/growth/issues/226">bisq-network/growth#226</a><br>
Screenshots for PayTM implementation:<br>
<a href="https://gist.github.com/jmacxx/2bcf95607373c821990e82bdcfa2c3fd#gistcomment-3894407">https://gist.github.com/jmacxx/2bcf95607373c821990e82bdcfa2c3fd#gistcomment-3894407</a></p>
</li>
<li class="task-list-item">
<p><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> <strong>UPI</strong><br>
<span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #225.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="792618052" data-permission-text="Title is private" data-url="https://github.com/bisq-network/growth/issues/225" data-hovercard-type="issue" data-hovercard-url="/bisq-network/growth/issues/225/hovercard" href="https://github.com/bisq-network/growth/issues/225">bisq-network/growth#225</a><br>
Screenshots for UPI implementation:<br>
<a href="https://gist.github.com/jmacxx/5d9dbdc80a7ad9e8b5847be548ed9b99#gistcomment-3894411">https://gist.github.com/jmacxx/5d9dbdc80a7ad9e8b5847be548ed9b99#gistcomment-3894411</a></p>
</li>
<li class="task-list-item">
<p><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> <strong>RTGS</strong><br>
<span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #237.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="809890950" data-permission-text="Title is private" data-url="https://github.com/bisq-network/growth/issues/237" data-hovercard-type="issue" data-hovercard-url="/bisq-network/growth/issues/237/hovercard" href="https://github.com/bisq-network/growth/issues/237">bisq-network/growth#237</a><br>
Screenshots for RTGS implementation:<br>
<a href="https://gist.github.com/jmacxx/0dab93fb6dcda158dd930c0ed4120290#gistcomment-3894416">https://gist.github.com/jmacxx/0dab93fb6dcda158dd930c0ed4120290#gistcomment-3894416</a></p>
</li>
<li class="task-list-item">
<p><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> <strong>NEFT</strong><br>
<span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #236.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="809881687" data-permission-text="Title is private" data-url="https://github.com/bisq-network/growth/issues/236" data-hovercard-type="issue" data-hovercard-url="/bisq-network/growth/issues/236/hovercard" href="https://github.com/bisq-network/growth/issues/236">bisq-network/growth#236</a><br>
Screenshots for NEFT implementation:<br>
<a href="https://gist.github.com/jmacxx/61df5ac79581bd4a6e8458a998762063#gistcomment-3894447">https://gist.github.com/jmacxx/61df5ac79581bd4a6e8458a998762063#gistcomment-3894447</a></p>
</li>
<li class="task-list-item">
<p><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> <strong>IMPS</strong><br>
<span class="issue-keyword tooltipped tooltipped-se" aria-label="This pull request closes issue #224.">Closes</span> <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="792609285" data-permission-text="Title is private" data-url="https://github.com/bisq-network/growth/issues/224" data-hovercard-type="issue" data-hovercard-url="/bisq-network/growth/issues/224/hovercard" href="https://github.com/bisq-network/growth/issues/224">bisq-network/growth#224</a><br>
Screenshots for IMPS implementation:<br>
<a href="https://gist.github.com/jmacxx/fd60d9f343e88f3d3b806a2d893be487#gistcomment-3894453">https://gist.github.com/jmacxx/fd60d9f343e88f3d3b806a2d893be487#gistcomment-3894453</a></p>
</li>
</ul>
<hr>
<h3>Note to reviewers:</h3>
<p>All payment methods are specific to India / INR currency and are implemented using <code>CountryBasedPaymentAccount</code>.</p>
<p>Three of the payment methods (RTGS/NETF/IMPS) are payment networks which use <a href="https://www.theifsccode.com/" rel="nofollow">IFS Code</a> and account number as the payee id. Since they function the same, code re-use was attained by inheriting from <code>IfscBasedAccountPayload</code> and using <code>IfscBankForm</code> to do the common GUI work.</p>
<p>The other two payment methods (PayTM, UPI) are regular single field payId accounts.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq/pull/5696'>https://github.com/bisq-network/bisq/pull/5696</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Add five Indian payment methods</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-ddfe2561e2851b1be1851813f1875188b3fe29fa7a604098e5aa6c029be1ecb5">core/src/main/java/bisq/core/payment/ImpsAccount.java</a>
(36)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-48618d1ba5b1a370df32bb791dc1b50e982961ae96fd5677d2ad40b8561f7969">core/src/main/java/bisq/core/payment/NeftAccount.java</a>
(36)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-11507f8864c1ddf3d166bb552b66dc80532ae543d294f2e12c98ab21278e922c">core/src/main/java/bisq/core/payment/PaymentAccountFactory.java</a>
(10)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-2e8fad88d61583121c01336220998a12d8fd0b6dfc14157fd5dc61167160b438">core/src/main/java/bisq/core/payment/PaytmAccount.java</a>
(44)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-d7a73aa9a699fec6710cc36ae3951defd4e46e86573c70d9fd1412d10cf5d084">core/src/main/java/bisq/core/payment/RtgsAccount.java</a>
(36)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-26ceed5209839ada5a5d8e8b58d978709ec01d8d5bb8feebd4c78c0390eb6f63">core/src/main/java/bisq/core/payment/UpiAccount.java</a>
(44)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-8b547a397c682ab576cd09718602adb3c160d2feae93a4545fa61ef6f5e66c4d">core/src/main/java/bisq/core/payment/payload/IfscBasedAccountPayload.java</a>
(96)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-2e76747c52215951d04f63095247f7ffc1686edc56e104b5f60f7ac358f0830e">core/src/main/java/bisq/core/payment/payload/ImpsAccountPayload.java</a>
(115)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-2d3cd091f86d60debca9b494cda6c555e3025ff92fa2d71404cdd3d7b9c6a4c4">core/src/main/java/bisq/core/payment/payload/NeftAccountPayload.java</a>
(115)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-4dcea846295ebb8de4e9633b0440ee222f5535c12fb168576b11e674e04ce60f">core/src/main/java/bisq/core/payment/payload/PaymentMethod.java</a>
(19)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-d6155337c87016284fc4b8030d0e1811ec40e75ba1a1c05e197c128c910eeee6">core/src/main/java/bisq/core/payment/payload/PaytmAccountPayload.java</a>
(99)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-a483071f2be50526b0e4188711ca506fbdcc39f3578090f19ba67c4223fd216c">core/src/main/java/bisq/core/payment/payload/RtgsAccountPayload.java</a>
(115)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-58737ea3a8fcd25bb67bf3cf74d4e3816d6d8bb29bbc02d56f3b094cdae6ac10">core/src/main/java/bisq/core/payment/payload/UpiAccountPayload.java</a>
(99)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-ebf0517b78fd6fd90d4a92f2b50757fe17da8d8c7d185ea9836c7b22ffba1989">core/src/main/java/bisq/core/proto/CoreProtoResolver.java</a>
(23)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-ee3e6ab6efe02715d897f3f01ac2ea73097880835637201e3e8c7ac80d34fde7">core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-a6cc570e0f56a36136791beae8f497706216230467708be9343344cd953e5f08">core/src/main/resources/i18n/displayStrings.properties</a>
(23)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-14c621cc7ce6218262fcf6a499c1c2a88f40247d1c35da3caf74ef3637d1d0f6">desktop/src/main/java/bisq/desktop/components/paymentmethods/IfscBankForm.java</a>
(132)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-bfbb392156dd33405a5185c96d21a4339ee139838e61e5fb63595d81b8a55330">desktop/src/main/java/bisq/desktop/components/paymentmethods/ImpsForm.java</a>
(38)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-b343923e6dda87f94f26a605fa5980eada8f254f7c1f83c9b3de1445b0e7b98b">desktop/src/main/java/bisq/desktop/components/paymentmethods/NeftForm.java</a>
(38)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-4b479acfce1ab92c8826a3c5bdba5a4927ad496db9b726b6ef05eb265780e998">desktop/src/main/java/bisq/desktop/components/paymentmethods/PaytmForm.java</a>
(106)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-dc1750978fdc2f2cf906384166c7350342fedf1e801b32eb0bdd2bf71afa3870">desktop/src/main/java/bisq/desktop/components/paymentmethods/RtgsForm.java</a>
(38)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-80acad4600f1321dff30b2432070e5e89789944d2f95803581848a3f35d6b792">desktop/src/main/java/bisq/desktop/components/paymentmethods/UpiForm.java</a>
(106)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-c5abb5ef938520e00047e774840a1990b4210c048e3f3fdf7478edca3935c0cb">desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-6b3e5b39ab1542f5a30794a99a6ca05a2e8a860dd4308dd3246589c41eca7db3">desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq/pull/5696/files#diff-51dcd1d852312df65738ff2bd493fdb0f187f50fb7d7324158c8b57fc1de7da7">proto/src/main/proto/pb.proto</a>
(31)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq/pull/5696.patch'>https://github.com/bisq-network/bisq/pull/5696.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq/pull/5696.diff'>https://github.com/bisq-network/bisq/pull/5696.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5696">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNW2Y7NJSZB6MPLEICTUCECLFANCNFSM5EDJOW3Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AJFFTNQNQ2VRCPXVITNNUP3UCECLFA5CNFSM5EDJOW32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4O3U3DFQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5696",
"url": "https://github.com/bisq-network/bisq/pull/5696",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>