<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5608#discussion_r714053462">common/src/main/java/bisq/common/file/JsonFileManager.java</a>:</p>
<pre style='color:#555'>>      }
 
-    public void writeToDisc(String json, String fileName) {
+    public Optional<String> read(String fileName) {
+        File jsonFile = new File(Paths.get(dir.getAbsolutePath(), fileName + ".json").toString());
+        if (!jsonFile.exists()) {
+            return Optional.empty();
+        }
+        StringBuilder json = new StringBuilder();
+        try (Scanner scanner = new Scanner(jsonFile)) {
+            while (scanner.hasNext()) {
+                json.append(scanner.next());
+            }
+        } catch (FileNotFoundException e) {
+            e.printStackTrace();
+        }
</pre>
<p>Shouldn't line 96 be <code>log.error("", e);</code>  if not a thrown exception?  Stack traces printed to std.err can be out of sync with the logger's buffer flushing -- it can make the timing of the stack trace in the bisq.log file a bit confusing.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5608#pullrequestreview-761066704">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNRX64HBJJICKRP4AKDUDHXY5ANCNFSM474M45YQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AJFFTNQP6MFPHXPZRYOADRLUDHXY5A5CNFSM474M45Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFVOPJUA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5608#pullrequestreview-761066704",
"url": "https://github.com/bisq-network/bisq/pull/5608#pullrequestreview-761066704",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>