<p></p>
<p><b>@ghubstan</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/5608#discussion_r714068989">core/src/main/java/bisq/core/dao/node/explorer/ExportJsonFilesService.java</a>:</p>
<pre style='color:#555'>> +                })
+                .collect(Collectors.toList());
+
+        ListenableFuture<Void> future = executor.submit(() -> {
+            log.info("Write chainHeight={}, jsonBlockList={}, jsonTxs={}, jsonTxOutputs={}",
+                    chainHeight, jsonBlockList.size(), jsonTxs.size(), jsonTxOutputs.size());
+            chainHeightFileManager.write(String.valueOf(chainHeight), "chainHeight");
+            jsonBlockList.forEach(jsonBlock -> blocksFileManager.write(Utilities.objectToJson(jsonBlock), jsonBlock.getHeight() + "_" + jsonBlock.getHash()));
+            jsonTxs.forEach(jsonTx -> txFileManager.write(Utilities.objectToJson(jsonTx), jsonTx.getId()));
+            jsonTxOutputs.forEach(jsonTxOutput -> txOutputFileManager.write(Utilities.objectToJson(jsonTxOutput), jsonTxOutput.getId()));
+            return null;
+        });
+
+        Futures.addCallback(future, Utilities.failureCallback(throwable -> {
+            log.error(throwable.toString());
+            throwable.printStackTrace();
</pre>
<p>Isn't this t.printStackTrace() redundant?  You just logged the error, with stack trace.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/5608#pullrequestreview-761088063">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJFFTNQCEAYTFWOWHGZ3U3TUDHZXPANCNFSM474M45YQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AJFFTNRXRVELLPFGHIUJAMLUDHZXPA5CNFSM474M45Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFVOUQPY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/5608#pullrequestreview-761088063",
"url": "https://github.com/bisq-network/bisq/pull/5608#pullrequestreview-761088063",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>