<p>the first address generated by the HD wallet gets reused repeatedly, other addresses were used, only once per address, but these are clustered around the first address (e.g. with oxt.me) , allowing transactions to be linked. this also discloses disclosing balances etc to counterparties who may have personally identifying information due to the nature of the transfers</p>
<p>as far as i can tell this is because <code>getOrCreateUnusedAddressEntry</code> is only used in <code>completePreparedGenericProposalTx</code>, whereas <a href="https://github.com/bisq-network/bisq-core/blob/0d830b74478b1b70365a7d02daa76ac11380e3b0/src/main/java/bisq/core/btc/wallet/BtcWalletService.java#L450">change address generation</a> uses <code>getOrCreateAddressEntry</code>. i've not attempted to verify this claim, i only spent a few minutes browsing through the code.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-desktop/issues/1540">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtgwJRsZF0yMY2_6TTbrJz1h3Eujkks5tyxrjgaJpZM4UAB0o">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtu6sZr1v5c9cyg3DTJsECjFcENS3ks5tyxrjgaJpZM4UAB0o.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/bisq-network/bisq-desktop/issues/1540"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-desktop","title":"bisq-network/bisq-desktop","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-desktop"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"First wallet address gets reused (#1540)"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq-desktop/issues/1540"}}}</script>
<script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"First wallet address gets reused (#1540)","sections":[{"text":"","activityTitle":"**Yuval Kogman**","activityImage":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","activitySubtitle":"@nothingmuch","facts":[{"name":"Repository: ","value":"bisq-network/bisq-desktop"},{"name":"Issue #: ","value":1540}]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"bisq-network/bisq-desktop\",\"issueId\":1540,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close issue","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueClose\",\"repositoryFullName\":\"bisq-network/bisq-desktop\",\"issueId\":1540}"},{"targets":[{"os":"default","uri":"https://github.com/bisq-network/bisq-desktop/issues/1540"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":335551784}"}],"themeColor":"26292E"}</script>