<ul>
<li>See: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="314334083" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-desktop/issues/1511" href="https://github.com/bisq-network/bisq-desktop/issues/1511">bisq-network/bisq-desktop#1511</a></li>
</ul>
<p><a class="user-mention" data-hovercard-user-id="170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> Not tested much yet but seems it covers all appearances of volume. Main question is how we avoid confusion of users if the volume amount does not change when the user changes the price.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/116'>https://github.com/bisq-network/bisq-core/pull/116</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Round volume of fiat amounts</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/116/files#diff-0">src/main/java/bisq/core/monetary/Price.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/116/files#diff-1">src/main/java/bisq/core/offer/Offer.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/116/files#diff-2">src/main/java/bisq/core/util/CoinUtil.java</a>
    (13)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/116.patch'>https://github.com/bisq-network/bisq-core/pull/116.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/116.diff'>https://github.com/bisq-network/bisq-core/pull/116.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/116">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthIUDnIeTcdGv-sWN9DF32tUulyhks5t2YGugaJpZM4UO-Ki">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtolNDLx6hmfHM1EvpJ2dncyKhCRGks5t2YGugaJpZM4UO-Ki.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-core/pull/116","url":"https://github.com/bisq-network/bisq-core/pull/116","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"[WIP] Round volume of fiat amounts (#116)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/116"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "[WIP] Round volume of fiat amounts (#116)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "78dece9",
"value": "Round volume of fiat amounts"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/core/monetary/Price.java](https://github.com/bisq-network/bisq-core/pull/116/files#diff-0) (12 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/offer/Offer.java](https://github.com/bisq-network/bisq-core/pull/116/files#diff-1) (9 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/util/CoinUtil.java](https://github.com/bisq-network/bisq-core/pull/116/files#diff-2) (13 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 116,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 116\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/116"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/116.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/116.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 339468962\n}"
}
],
"themeColor": "26292E"
}</script>