<p>I checked the currencies which have a larger value than USD:<br>
<a href="http://sassyfeeds.com/top-10-expensive-currency-world-today/" rel="nofollow">http://sassyfeeds.com/top-10-expensive-currency-world-today/</a><br>
If we simply remove the decimal value from the fiat amount it would still not hurt too much even with the most expensive currency (Kuwait Dinar).</p>
<p>As the lowest BTC value the user can enter is 0.0001 BTC and that is below 1 USD we need to ensure that the fiat value is at least 1. Usual rounding can be used, just in case it results in 0 we need to change to 1.</p>
<p>The open question is how we communicate that rounding to the user to avoid confusion?<br>
Specially if he changes the price and does not see any effect in the volume he might get confused.</p>
<p><a class="user-mention" data-hovercard-user-id="170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> Any idea? An info icon might do it...</p>
<p>The PRs at <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326750006" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-core/issues/116" href="https://github.com/bisq-network/bisq-core/pull/116">bisq-network/bisq-core#116</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="326750058" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-desktop/issues/1558" href="https://github.com/bisq-network/bisq-desktop/pull/1558">#1558</a><br>
are not ready for merge and not much tested. Percentage based price changes are not tested as well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-desktop/issues/1511#issuecomment-392272121">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqXhhbCXKUWRc2FXDK4nVequp0fsks5t2YJTgaJpZM4TVF3d">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZts2sYSZ4KAfgIdnSV8mbelwTbYtWks5t2YJTgaJpZM4TVF3d.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-desktop/issues/1511#issuecomment-392272121","url":"https://github.com/bisq-network/bisq-desktop/issues/1511#issuecomment-392272121","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-desktop","title":"bisq-network/bisq-desktop","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-desktop"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #1511: I checked the currencies which have a larger value than USD:\r\nhttp://sassyfeeds.com/top-10-expensive-currency-world-today/\r\nIf we simply remove the decimal value from the fiat amount it would still not hurt too much even with the most expensive currency (Kuwait Dinar).\r\n\r\nAs the lowest BTC value the user can enter is 0.0001 BTC and that is below 1 USD we need to ensure that the fiat value is at least 1. Usual rounding can be used, just in case it results in 0 we need to change to 1.\r\n\r\nThe open question is how we communicate that rounding to the user to avoid confusion?\r\nSpecially if he changes the price and does not see any effect in the volume he might get confused.\r\n\r\n@ripcurlx Any idea? An info icon might do it...\r\n\r\nThe PRs at https://github.com/bisq-network/bisq-core/pull/116 and https://github.com/bisq-network/bisq-desktop/pull/1558\r\nare not ready for merge and not much tested. Percentage based price changes are not tested as well."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq-desktop/issues/1511#issuecomment-392272121"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [bisq-network/bisq-desktop] Option to have fiat values rounded to full euros, 0 cents (#1511)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-desktop\",\n\"issueId\": 1511,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq-desktop\",\n\"issueId\": 1511\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-desktop/issues/1511#issuecomment-392272121"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 324296157\n}"
}
],
"themeColor": "26292E"
}</script>