[bisq-network/bisq-desktop] Add mobile notifications (#1624)

Christoph Atteneder notifications at github.com
Wed Aug 15 12:51:58 UTC 2018


ripcurlx requested changes on this pull request.

Please reset the version and naming used for the local test build. Besides that utACK

> @@ -15,7 +16,7 @@ apply plugin: 'witness'
 apply plugin: 'com.github.johnrengelman.shadow'
 
 group = 'network.bisq'
-version = '0.7.1-SNAPSHOT'
+version = '0.8.0'

Shouldn't we only do this during the release?

>      jcenter()
     maven { url 'https://jitpack.io' }
     maven { url 'https://raw.githubusercontent.com/JesusMcCloud/tor-binary/master/release/' }
     maven { url 'https://dl.bintray.com/jerady/maven' }
 }
 
 dependencies {
-    compile 'network.bisq:bisq-p2p:-SNAPSHOT'
-    compile 'network.bisq:bisq-core:-SNAPSHOT'
-    compile 'network.bisq:bisq-common:-SNAPSHOT'
+    compile 'network.bisq:bisq-p2p:0.8.0'
+    compile 'network.bisq:bisq-core:0.8.0'
+    compile 'network.bisq:bisq-common:0.8.0'

Same here: I think this should be -SNAPSHOT when merging

> @@ -33,25 +34,29 @@ tasks.withType(JavaCompile) {
 sourceSets.main.resources.srcDirs += ['src/main/java'] // to copy fxml and css files
 
 repositories {
+    mavenLocal()

Was this only for testing purposes locally?

> @@ -82,18 +82,18 @@ $JAVA_HOME/bin/javapackager \
     -Bicon=package/osx/Bisq.icns \
     -Bruntime="$JAVA_HOME/jre" \
     -native dmg \
-    -name Bisq \
-    -title Bisq \
+    -name Bisq_notifications \
+    -title Bisq_notifications \

Also shouldn't be changed here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-desktop/pull/1624#pullrequestreview-146430489
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180815/dc8d16dd/attachment-0001.html>


More information about the bisq-github mailing list