[bisq-network/bisq-core] PriceFeedService#applyLatestPrice() refactoring (#149)

tau3 notifications at github.com
Wed Aug 15 14:04:46 UTC 2018


Hello!

I saw a comment that `applyLatestBisqMarketPrice` can take some time and refactored it using parallel streams. So (in theory) it can perform calculation routines faster. State of `PriceFeedService` is updated in old way because the class is not thread-safe.

If the idea of parrallel streams is bad, implemented unit test can be kept anyway and this branch (with implementation of fallback to ordinary streams) can still be considered as cleanup attempt.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq-core/pull/149

-- Commit Summary --

  * initial refactoring
  * implemented unit test for PriceFeedService#applyLatestBisqMarketPrice()

-- File Changes --

    M src/main/java/bisq/core/provider/price/PriceFeedService.java (68)
    A src/test/java/bisq/core/provider/price/PriceFeedServiceTest.java (67)

-- Patch Links --

https://github.com/bisq-network/bisq-core/pull/149.patch
https://github.com/bisq-network/bisq-core/pull/149.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/149
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180815/3f76dd57/attachment-0001.html>


More information about the bisq-github mailing list